database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-11 04:22:52 +03:00
Code Activity

Don't try to run clauseless index scans on index types that don't support

Browse Source 
it.  Per report from Marinos Yannikos.
This commit is contained in:
Tom Lane
2005-04-20 21:48:31 +00:00
parent 7735c39aa0
commit daa7e6604c
1 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/backend/optimizer/path/indxpath.c
View File

@@ -9,7 +9,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/optimizer/path/indxpath.c,v 1.124.2.1 2003/03/23 01:49:13 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/optimizer/path/indxpath.c,v 1.124.2.2 2005/04/20 21:48:31 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@@ -188,11 +188,16 @@ create_index_paths(Query *root, RelOptInfo *rel)
* 3. Compute pathkeys describing index's ordering, if any, then * 3. Compute pathkeys describing index's ordering, if any, then
* see how many of them are actually useful for this query. * see how many of them are actually useful for this query.
*/ */
index_pathkeys = build_index_pathkeys(root, rel, index, index_is_ordered = OidIsValid(index->ordering[0]);
ForwardScanDirection); if (index_is_ordered)
index_is_ordered = (index_pathkeys != NIL); {
useful_pathkeys = truncate_useless_pathkeys(root, rel, index_pathkeys = build_index_pathkeys(root, rel, index,
index_pathkeys); ForwardScanDirection);
useful_pathkeys = truncate_useless_pathkeys(root, rel,
index_pathkeys);
}
else
useful_pathkeys = NIL;
/* /*
* 4. Generate an indexscan path if there are relevant restriction * 4. Generate an indexscan path if there are relevant restriction
@@ -202,10 +207,15 @@ create_index_paths(Query *root, RelOptInfo *rel)
* If there is a predicate, consider it anyway since the index * If there is a predicate, consider it anyway since the index
* predicate has already been found to match the query. The * predicate has already been found to match the query. The
* selectivity of the predicate might alone make the index useful. * selectivity of the predicate might alone make the index useful.
*
* Note: not all index AMs support scans with no restriction clauses.
* We assume here that the AM does so if and only if it supports
* ordered scans. (It would probably be better if there were a
* specific flag for this in pg_am, but there's not.)
*/ */
if (restrictclauses != NIL || if (restrictclauses != NIL ||
useful_pathkeys != NIL || useful_pathkeys != NIL ||
index->indpred != NIL) (index->indpred != NIL && index_is_ordered))
add_path(rel, (Path *) add_path(rel, (Path *)
create_index_path(root, rel, index, create_index_path(root, rel, index,
restrictclauses, restrictclauses,