database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-05 09:19:17 +03:00
Code

Plug memory leak in index_get_partition

Browse Source 
The list of indexes was being leaked when asked for an index that
doesn't have an index partition in the table partition.  Not a common
case admittedly --and in most cases where it occurs, caller throws an
error anyway-- but worth fixing for cleanliness and in case any
third-party code is calling this function.

While at it, remove use of lfirst_oid() to obtain a value we already
have.

Author: Justin Pryzby <pryzby@telsasoft.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/20201105203606.GF22691@telsasoft.com
This commit is contained in:
Alvaro Herrera 2020-11-06 22:52:15 -03:00
parent 6a7b55f371
commit d94d37f8c0
No known key found for this signature in database
GPG Key ID: 1C20ACB9D5C564AE
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/catalog/partition.c
View File

@ -170,13 +170,14 @@ index_get_partition(Relation partition, Oid indexId)
ReleaseSysCache(tup); ReleaseSysCache(tup);
if (!ispartition) if (!ispartition)
continue; continue;
if (get_partition_parent(lfirst_oid(l)) == indexId) if (get_partition_parent(partIdx) == indexId)
{ {
list_free(idxlist); list_free(idxlist);
return partIdx; return partIdx;
} }
} }
list_free(idxlist);
return InvalidOid; return InvalidOid;
} }