database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Revert "Add sortsupport for gist_btree opclasses, for faster index builds."

Browse Source 
This reverts commit 9f984ba6d2.

It was making the buildfarm unhappy, apparently setting client_min_messages
in a regression test produces different output if log_statement='all'.
Another issue is that I now suspect the bit sortsupport function was in
fact not correct to call byteacmp(). Revert to investigate both of those
issues.
This commit is contained in:
Heikki Linnakangas
2021-04-07 14:33:21 +03:00
parent 9f984ba6d2
commit d92b1cdbab
77 changed files with 3 additions and 1530 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
contrib/btree_gist/btree_ts.c
View File

@ -31,7 +31,6 @@ PG_FUNCTION_INFO_V1(gbt_tstz_consistent);
PG_FUNCTION_INFO_V1(gbt_tstz_distance);
PG_FUNCTION_INFO_V1(gbt_ts_penalty);
PG_FUNCTION_INFO_V1(gbt_ts_same);
PG_FUNCTION_INFO_V1(gbt_ts_sortsupport);
#ifdef USE_FLOAT8_BYVAL
@ -400,29 +399,3 @@ gbt_ts_same(PG_FUNCTION_ARGS)
*result = gbt_num_same((void *) b1, (void *) b2, &tinfo, fcinfo->flinfo);
PG_RETURN_POINTER(result);
}
static int
gbt_ts_sort_build_cmp(Datum a, Datum b, SortSupport ssup)
{
tsKEY *ia = (tsKEY *) DatumGetPointer(a);
tsKEY *ib = (tsKEY *) DatumGetPointer(b);
return DatumGetInt32(DirectFunctionCall2(timestamp_cmp,
TimestampGetDatumFast(ia->lower),
TimestampGetDatumFast(ib->lower)));
}
/*
* Sort support routine for fast GiST index build by sorting.
*/
Datum
gbt_ts_sortsupport(PG_FUNCTION_ARGS)
{
SortSupport ssup = (SortSupport) PG_GETARG_POINTER(0);
ssup->comparator = gbt_ts_sort_build_cmp;
ssup->abbrev_converter = NULL;
ssup->abbrev_abort = NULL;
ssup->abbrev_full_comparator = NULL;
PG_RETURN_VOID();
}