mirror of
https://github.com/postgres/postgres.git
synced 2025-07-27 12:41:57 +03:00
Revert "Add sortsupport for gist_btree opclasses, for faster index builds."
This reverts commit 9f984ba6d2
.
It was making the buildfarm unhappy, apparently setting client_min_messages
in a regression test produces different output if log_statement='all'.
Another issue is that I now suspect the bit sortsupport function was in
fact not correct to call byteacmp(). Revert to investigate both of those
issues.
This commit is contained in:
@ -25,7 +25,6 @@ PG_FUNCTION_INFO_V1(gbt_date_consistent);
|
||||
PG_FUNCTION_INFO_V1(gbt_date_distance);
|
||||
PG_FUNCTION_INFO_V1(gbt_date_penalty);
|
||||
PG_FUNCTION_INFO_V1(gbt_date_same);
|
||||
PG_FUNCTION_INFO_V1(gbt_date_sortsupport);
|
||||
|
||||
static bool
|
||||
gbt_dategt(const void *a, const void *b, FmgrInfo *flinfo)
|
||||
@ -258,29 +257,3 @@ gbt_date_same(PG_FUNCTION_ARGS)
|
||||
*result = gbt_num_same((void *) b1, (void *) b2, &tinfo, fcinfo->flinfo);
|
||||
PG_RETURN_POINTER(result);
|
||||
}
|
||||
|
||||
static int
|
||||
gbt_date_sort_build_cmp(Datum a, Datum b, SortSupport ssup)
|
||||
{
|
||||
dateKEY *ia = (dateKEY *) PointerGetDatum(a);
|
||||
dateKEY *ib = (dateKEY *) PointerGetDatum(b);
|
||||
|
||||
return DatumGetInt32(DirectFunctionCall2(date_cmp,
|
||||
DateADTGetDatum(ia->lower),
|
||||
DateADTGetDatum(ib->lower)));
|
||||
}
|
||||
|
||||
/*
|
||||
* Sort support routine for fast GiST index build by sorting.
|
||||
*/
|
||||
Datum
|
||||
gbt_date_sortsupport(PG_FUNCTION_ARGS)
|
||||
{
|
||||
SortSupport ssup = (SortSupport) PG_GETARG_POINTER(0);
|
||||
|
||||
ssup->comparator = gbt_date_sort_build_cmp;
|
||||
ssup->abbrev_converter = NULL;
|
||||
ssup->abbrev_abort = NULL;
|
||||
ssup->abbrev_full_comparator = NULL;
|
||||
PG_RETURN_VOID();
|
||||
}
|
||||
|
Reference in New Issue
Block a user