database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-11 20:28:21 +03:00
Code Activity

Revert "Add sortsupport for gist_btree opclasses, for faster index builds."

Browse Source 
This reverts commit 9f984ba6d2.

It was making the buildfarm unhappy, apparently setting client_min_messages
in a regression test produces different output if log_statement='all'.
Another issue is that I now suspect the bit sortsupport function was in
fact not correct to call byteacmp(). Revert to investigate both of those
issues.
This commit is contained in:
Heikki Linnakangas
2021-04-07 14:33:21 +03:00
parent 9f984ba6d2
commit d92b1cdbab
77 changed files with 3 additions and 1530 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
contrib/btree_gist/btree_bit.c
View File

@ -19,7 +19,6 @@ PG_FUNCTION_INFO_V1(gbt_bit_picksplit);
PG_FUNCTION_INFO_V1(gbt_bit_consistent);
PG_FUNCTION_INFO_V1(gbt_bit_penalty);
PG_FUNCTION_INFO_V1(gbt_bit_same);
PG_FUNCTION_INFO_V1(gbt_bit_sortsupport);
/* define for comparison */
@ -210,27 +209,3 @@ gbt_bit_penalty(PG_FUNCTION_ARGS)
PG_RETURN_POINTER(gbt_var_penalty(result, o, n, PG_GET_COLLATION(),
&tinfo, fcinfo->flinfo));
}
static int
gbt_bit_sort_build_cmp(Datum a, Datum b, SortSupport ssup)
{
/* Use byteacmp(), like gbt_bitcmp() does */
return DatumGetInt32(DirectFunctionCall2(byteacmp,
PointerGetDatum(a),
PointerGetDatum(b)));
}
/*
* Sort support routine for fast GiST index build by sorting.
*/
Datum
gbt_bit_sortsupport(PG_FUNCTION_ARGS)
{
SortSupport ssup = (SortSupport) PG_GETARG_POINTER(0);
ssup->comparator = gbt_bit_sort_build_cmp;
ssup->abbrev_converter = NULL;
ssup->abbrev_abort = NULL;
ssup->abbrev_full_comparator = NULL;
PG_RETURN_VOID();
}