From d8b0c64116483c1ce9711e66700dddd709941a22 Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Wed, 25 Dec 2024 19:22:25 +0200 Subject: [PATCH] meson: Export all libcommon functions in Windows builds This fixes "unresolved external symbol" errors with extensions that use functions from libpgport that need special CFLAGS to compile. Currently, that includes the CRC-32 functions. Commit 2571c1d5cc did this for libcommon, but I missed that libpqport has the same issue. Reported-by: Tom Lane Backpatch-through: 16, where Meson was introduced Discussion: https://www.postgresql.org/message-id/CAOdR5yF0krWrxycA04rgUKCgKugRvGWzzGLAhDZ9bzNv8g0Lag@mail.gmail.com --- src/port/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/port/meson.build b/src/port/meson.build index fd9ee199d1b..90f837248de 100644 --- a/src/port/meson.build +++ b/src/port/meson.build @@ -185,6 +185,7 @@ foreach name, opts : pgport_variants lib = static_library('libpgport@0@'.format(name), pgport_sources, link_with: cflag_libs, + link_whole: cflag_libs, c_pch: pch_c_h, kwargs: opts + { 'dependencies': opts['dependencies'] + [ssl],