mirror of
https://github.com/postgres/postgres.git
synced 2025-07-27 12:41:57 +03:00
Add construct_array_builtin, deconstruct_array_builtin
There were many calls to construct_array() and deconstruct_array() for built-in types, for example, when dealing with system catalog columns. These all hardcoded the type attributes necessary to pass to these functions. To simplify this a bit, add construct_array_builtin(), deconstruct_array_builtin() as wrappers that centralize this hardcoded knowledge. This simplifies many call sites and reduces the amount of hardcoded stuff that is spread around. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/2914356f-9e5f-8c59-2995-5997fc48bcba%40enterprisedb.com
This commit is contained in:
@ -564,21 +564,11 @@ hash_metapage_info(PG_FUNCTION_ARGS)
|
||||
|
||||
for (i = 0; i < HASH_MAX_SPLITPOINTS; i++)
|
||||
spares[i] = Int64GetDatum((int64) metad->hashm_spares[i]);
|
||||
values[j++] = PointerGetDatum(construct_array(spares,
|
||||
HASH_MAX_SPLITPOINTS,
|
||||
INT8OID,
|
||||
sizeof(int64),
|
||||
FLOAT8PASSBYVAL,
|
||||
TYPALIGN_DOUBLE));
|
||||
values[j++] = PointerGetDatum(construct_array_builtin(spares, HASH_MAX_SPLITPOINTS, INT8OID));
|
||||
|
||||
for (i = 0; i < HASH_MAX_BITMAPS; i++)
|
||||
mapp[i] = Int64GetDatum((int64) metad->hashm_mapp[i]);
|
||||
values[j++] = PointerGetDatum(construct_array(mapp,
|
||||
HASH_MAX_BITMAPS,
|
||||
INT8OID,
|
||||
sizeof(int64),
|
||||
FLOAT8PASSBYVAL,
|
||||
TYPALIGN_DOUBLE));
|
||||
values[j++] = PointerGetDatum(construct_array_builtin(mapp, HASH_MAX_BITMAPS, INT8OID));
|
||||
|
||||
tuple = heap_form_tuple(tupleDesc, values, nulls);
|
||||
|
||||
|
Reference in New Issue
Block a user