mirror of
https://github.com/postgres/postgres.git
synced 2025-07-28 23:42:10 +03:00
Add construct_array_builtin, deconstruct_array_builtin
There were many calls to construct_array() and deconstruct_array() for built-in types, for example, when dealing with system catalog columns. These all hardcoded the type attributes necessary to pass to these functions. To simplify this a bit, add construct_array_builtin(), deconstruct_array_builtin() as wrappers that centralize this hardcoded knowledge. This simplifies many call sites and reduces the amount of hardcoded stuff that is spread around. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/2914356f-9e5f-8c59-2995-5997fc48bcba%40enterprisedb.com
This commit is contained in:
@ -425,11 +425,7 @@ bt_page_print_tuples(struct user_args *uargs)
|
||||
tids_datum = (Datum *) palloc(nposting * sizeof(Datum));
|
||||
for (int i = 0; i < nposting; i++)
|
||||
tids_datum[i] = ItemPointerGetDatum(&tids[i]);
|
||||
values[j++] = PointerGetDatum(construct_array(tids_datum,
|
||||
nposting,
|
||||
TIDOID,
|
||||
sizeof(ItemPointerData),
|
||||
false, TYPALIGN_SHORT));
|
||||
values[j++] = PointerGetDatum(construct_array_builtin(tids_datum, nposting, TIDOID));
|
||||
pfree(tids_datum);
|
||||
}
|
||||
else
|
||||
|
Reference in New Issue
Block a user