database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-05 07:21:24 +03:00
Code Activity

connoinherit may be true only for CHECK constraints

Browse Source 
The code was setting it true for other constraints, which is
bogus.  Doing so caused bogus catalog entries for such constraints, and
in particular caused an error to be raised when trying to drop a
constraint of types other than CHECK from a table that has children,
such as reported in bug #6712.

In 9.2, additionally ignore connoinherit=true for other constraint
types, to avoid having to force initdb; existing databases might already
contain bogus catalog entries.

Includes a catversion bump (in HEAD only).

Bug report from Miroslav Šulc
Analysis from Amit Kapila and Noah Misch; Amit also contributed the patch.
This commit is contained in:
Alvaro Herrera
2012-07-20 12:33:34 -04:00
parent d7991a13d8
commit d721f208af
5 changed files with 169 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/commands/tablecmds.c
View File

@ -6039,7 +6039,7 @@ ATAddForeignKeyConstraint(AlteredTableInfo *tab, Relation rel,
NULL,
true, /* islocal */
0, /* inhcount */
false); /* isnoinherit */
true); /* isnoinherit */
/*
* Create the triggers that will enforce the constraint.
@ -6947,6 +6947,16 @@ ATExecDropConstraint(Relation rel, const char *constrName,
is_no_inherit_constraint = con->connoinherit;
/*
* XXX as a special hack, we turn on no-inherit here unconditionally
* except for CHECK constraints. This is because 9.2 until beta2
* contained a bug that marked it false for all constraints, even
* though it was only supported false for CHECK constraints.
* See bug #6712.
*/
if (con->contype != CONSTRAINT_CHECK)
is_no_inherit_constraint = true;
/*
* Perform the actual constraint deletion
*/