database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-03 22:24:49 +03:00
Code

During index build, check and elog (not just Assert) for broken HOT chain.

Browse Source 
The recently-fixed bug in WAL replay could result in not finding a parent
tuple for a heap-only tuple.  The existing code would either Assert or
generate an invalid index entry, neither of which is desirable.  Throw a
regular error instead.
This commit is contained in:
Tom Lane 2014-03-17 12:36:11 -04:00
parent d663d4399e
commit d70cf811f7
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/backend/catalog/index.c
View File

@ -2438,7 +2438,10 @@ IndexBuildHeapScan(Relation heapRelation,
rootTuple = *heapTuple; rootTuple = *heapTuple;
offnum = ItemPointerGetOffsetNumber(&heapTuple->t_self); offnum = ItemPointerGetOffsetNumber(&heapTuple->t_self);
Assert(OffsetNumberIsValid(root_offsets[offnum - 1])); if (!OffsetNumberIsValid(root_offsets[offnum - 1]))
elog(ERROR, "failed to find parent tuple for heap-only tuple at (%u,%u) in table \"%s\"",
ItemPointerGetBlockNumber(&heapTuple->t_self),
offnum, RelationGetRelationName(heapRelation));
ItemPointerSetOffsetNumber(&rootTuple.t_self, ItemPointerSetOffsetNumber(&rootTuple.t_self,
root_offsets[offnum - 1]); root_offsets[offnum - 1]);
@ -2856,7 +2859,11 @@ validate_index_heapscan(Relation heapRelation,
if (HeapTupleIsHeapOnly(heapTuple)) if (HeapTupleIsHeapOnly(heapTuple))
{ {
root_offnum = root_offsets[root_offnum - 1]; root_offnum = root_offsets[root_offnum - 1];
Assert(OffsetNumberIsValid(root_offnum)); if (!OffsetNumberIsValid(root_offnum))
elog(ERROR, "failed to find parent tuple for heap-only tuple at (%u,%u) in table \"%s\"",
ItemPointerGetBlockNumber(heapcursor),
ItemPointerGetOffsetNumber(heapcursor),
RelationGetRelationName(heapRelation));
ItemPointerSetOffsetNumber(&rootTuple, root_offnum); ItemPointerSetOffsetNumber(&rootTuple, root_offnum);
} }