database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-07 00:36:50 +03:00
Code Activity

Ensure COPY TO on an RLS-enabled table copies no more than it should.

Browse Source 
The COPY documentation is quite clear that "COPY relation TO" copies
rows from only the named table, not any inheritance children it may
have.  However, if you enabled row-level security on the table then
this stopped being true, because the code forgot to apply the ONLY
modifier in the "SELECT ... FROM relation" query that it constructs
in order to allow RLS predicates to be attached.  Fix that.

Report and patch by Antonin Houska (comment adjustments and test case
by me).  Back-patch to all supported branches.

Discussion: https://postgr.es/m/3472.1675251957@antos
This commit is contained in:
Tom Lane
2023-03-10 13:52:28 -05:00
parent c45dc7ffbb
commit d66bb048c3
4 changed files with 77 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/commands/copyto.c
View File

@ -524,8 +524,8 @@ BeginCopyTo(ParseState *pstate,
/*
* With row-level security and a user using "COPY relation TO", we
* have to convert the "COPY relation TO" to a query-based COPY (eg:
* "COPY (SELECT * FROM relation) TO"), to allow the rewriter to add
* in any RLS clauses.
* "COPY (SELECT * FROM ONLY relation) TO"), to allow the rewriter to
* add in any RLS clauses.
*
* When this happens, we are passed in the relid of the originally
* found relation (which we have locked). As the planner will look up