mirror of
https://github.com/postgres/postgres.git
synced 2025-07-07 00:36:50 +03:00
Ensure COPY TO on an RLS-enabled table copies no more than it should.
The COPY documentation is quite clear that "COPY relation TO" copies rows from only the named table, not any inheritance children it may have. However, if you enabled row-level security on the table then this stopped being true, because the code forgot to apply the ONLY modifier in the "SELECT ... FROM relation" query that it constructs in order to allow RLS predicates to be attached. Fix that. Report and patch by Antonin Houska (comment adjustments and test case by me). Back-patch to all supported branches. Discussion: https://postgr.es/m/3472.1675251957@antos
This commit is contained in:
@ -244,11 +244,14 @@ DoCopy(ParseState *pstate, const CopyStmt *stmt,
|
||||
|
||||
/*
|
||||
* Build RangeVar for from clause, fully qualified based on the
|
||||
* relation which we have opened and locked.
|
||||
* relation which we have opened and locked. Use "ONLY" so that
|
||||
* COPY retrieves rows from only the target table not any
|
||||
* inheritance children, the same as when RLS doesn't apply.
|
||||
*/
|
||||
from = makeRangeVar(get_namespace_name(RelationGetNamespace(rel)),
|
||||
pstrdup(RelationGetRelationName(rel)),
|
||||
-1);
|
||||
from->inh = false; /* apply ONLY */
|
||||
|
||||
/* Build query */
|
||||
select = makeNode(SelectStmt);
|
||||
|
Reference in New Issue
Block a user