mirror of
https://github.com/postgres/postgres.git
synced 2025-07-15 19:21:59 +03:00
Ensure COPY TO on an RLS-enabled table copies no more than it should.
The COPY documentation is quite clear that "COPY relation TO" copies rows from only the named table, not any inheritance children it may have. However, if you enabled row-level security on the table then this stopped being true, because the code forgot to apply the ONLY modifier in the "SELECT ... FROM relation" query that it constructs in order to allow RLS predicates to be attached. Fix that. Report and patch by Antonin Houska (comment adjustments and test case by me). Back-patch to all supported branches. Discussion: https://postgr.es/m/3472.1675251957@antos
This commit is contained in:
@ -244,11 +244,14 @@ DoCopy(ParseState *pstate, const CopyStmt *stmt,
|
||||
|
||||
/*
|
||||
* Build RangeVar for from clause, fully qualified based on the
|
||||
* relation which we have opened and locked.
|
||||
* relation which we have opened and locked. Use "ONLY" so that
|
||||
* COPY retrieves rows from only the target table not any
|
||||
* inheritance children, the same as when RLS doesn't apply.
|
||||
*/
|
||||
from = makeRangeVar(get_namespace_name(RelationGetNamespace(rel)),
|
||||
pstrdup(RelationGetRelationName(rel)),
|
||||
-1);
|
||||
from->inh = false; /* apply ONLY */
|
||||
|
||||
/* Build query */
|
||||
select = makeNode(SelectStmt);
|
||||
|
@ -524,8 +524,8 @@ BeginCopyTo(ParseState *pstate,
|
||||
/*
|
||||
* With row-level security and a user using "COPY relation TO", we
|
||||
* have to convert the "COPY relation TO" to a query-based COPY (eg:
|
||||
* "COPY (SELECT * FROM relation) TO"), to allow the rewriter to add
|
||||
* in any RLS clauses.
|
||||
* "COPY (SELECT * FROM ONLY relation) TO"), to allow the rewriter to
|
||||
* add in any RLS clauses.
|
||||
*
|
||||
* When this happens, we are passed in the relid of the originally
|
||||
* found relation (which we have locked). As the planner will look up
|
||||
|
Reference in New Issue
Block a user