database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-02 11:44:50 +03:00
Code

Reload configuration more frequently in apply worker.

Browse Source 
The apply worker was not reloading the configuration while processing
messages if there is a continuous flow of messages from upstream. It was
also not reloading the configuration if there is a change in the
configuration after it has waited for the message and before receiving the
new replication message. This can lead to failure in tests because we
expect that after reload, the behavior of apply worker to respect the
changed GUCs.

We found this while analyzing a rare buildfarm failure.

Author: Hou Zhijie
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/OS0PR01MB5716AF9079CC0755CD015322947E9@OS0PR01MB5716.jpnprd01.prod.outlook.com
This commit is contained in:
Amit Kapila 2023-06-07 09:19:17 +05:30
parent 95f0340c3b
commit d64e6468f4
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/replication/logical/worker.c
View File

@ -3562,6 +3562,12 @@ LogicalRepApplyLoop(XLogRecPtr last_received)
int c; int c;
StringInfoData s; StringInfoData s;
if (ConfigReloadPending)
{
ConfigReloadPending = false;
ProcessConfigFile(PGC_SIGHUP);
}
/* Reset timeout. */ /* Reset timeout. */
last_recv_timestamp = GetCurrentTimestamp(); last_recv_timestamp = GetCurrentTimestamp();
ping_sent = false; ping_sent = false;