mirror of
https://github.com/postgres/postgres.git
synced 2025-07-08 11:42:09 +03:00
Pass collations to functions in FunctionCallInfoData, not FmgrInfo.
Since collation is effectively an argument, not a property of the function, FmgrInfo is really the wrong place for it; and this becomes critical in cases where a cached FmgrInfo is used for varying purposes that might need different collation settings. Fix by passing it in FunctionCallInfoData instead. In particular this allows a clean fix for bug #5970 (record_cmp not working). This requires touching a bit more code than the original method, but nobody ever thought that collations would not be an invasive patch...
This commit is contained in:
@ -213,7 +213,8 @@ int2vectorrecv(PG_FUNCTION_ARGS)
|
||||
* fcinfo->flinfo->fn_extra. So we need to pass it our own flinfo
|
||||
* parameter.
|
||||
*/
|
||||
InitFunctionCallInfoData(locfcinfo, fcinfo->flinfo, 3, NULL, NULL);
|
||||
InitFunctionCallInfoData(locfcinfo, fcinfo->flinfo, 3,
|
||||
InvalidOid, NULL, NULL);
|
||||
|
||||
locfcinfo.arg[0] = PointerGetDatum(buf);
|
||||
locfcinfo.arg[1] = ObjectIdGetDatum(INT2OID);
|
||||
|
Reference in New Issue
Block a user