From d5d09692ea6b96944d24c44db1451f085b64ba09 Mon Sep 17 00:00:00 2001 From: Tomas Vondra Date: Sat, 2 May 2020 15:30:10 +0200 Subject: [PATCH] Remove superfluous memset from pgstat_recv_resetslrucounter The extra memset meant pg_stat_reset_slru() always reset all the entries even when reset of a single entry was requested, but the timestamp was left uninitialized. Reported-by: Atsushi Torikoshi Discussion: https://postgr.es/m/CACZ0uYFe16pjZxQYaTn53mspyM7dgMPYL3DJLjjPw69GMCC2Ow%40mail.gmail.com --- src/backend/postmaster/pgstat.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/backend/postmaster/pgstat.c b/src/backend/postmaster/pgstat.c index 2ba3858d31e..3f8105c6ebc 100644 --- a/src/backend/postmaster/pgstat.c +++ b/src/backend/postmaster/pgstat.c @@ -6233,8 +6233,6 @@ pgstat_recv_resetslrucounter(PgStat_MsgResetslrucounter *msg, int len) int i; TimestampTz ts = GetCurrentTimestamp(); - memset(&slruStats, 0, sizeof(slruStats)); - for (i = 0; i < SLRU_NUM_ELEMENTS; i++) { /* reset entry with the given index, or all entries (index is -1) */