1
0
mirror of https://github.com/postgres/postgres.git synced 2025-05-05 09:19:17 +03:00

Make GIN's cleanup pending list process interruptable

Cleanup process could be called by ordinary insert/update and could take a lot
of time. Add vacuum_delay_point() to make this process interruptable. Under
vacuum this call will also throttle a vacuum process to decrease system load,
called from insert/update it will not throttle, and that reduces a latency.

Backpatch for all supported branches.

Jeff Janes <jeff.janes@gmail.com>
This commit is contained in:
Teodor Sigaev 2015-09-07 17:17:15 +03:00
parent 552723a3bf
commit d592a8745f

View File

@ -801,7 +801,6 @@ ginInsertCleanup(GinState *ginstate,
*/ */
processPendingPage(&accum, &datums, page, FirstOffsetNumber); processPendingPage(&accum, &datums, page, FirstOffsetNumber);
if (vac_delay)
vacuum_delay_point(); vacuum_delay_point();
/* /*
@ -842,7 +841,6 @@ ginInsertCleanup(GinState *ginstate,
{ {
ginEntryInsert(ginstate, attnum, key, category, ginEntryInsert(ginstate, attnum, key, category,
list, nlist, NULL); list, nlist, NULL);
if (vac_delay)
vacuum_delay_point(); vacuum_delay_point();
} }
@ -923,7 +921,7 @@ ginInsertCleanup(GinState *ginstate,
/* /*
* Read next page in pending list * Read next page in pending list
*/ */
CHECK_FOR_INTERRUPTS(); vacuum_delay_point();
buffer = ReadBuffer(index, blkno); buffer = ReadBuffer(index, blkno);
LockBuffer(buffer, GIN_SHARE); LockBuffer(buffer, GIN_SHARE);
page = BufferGetPage(buffer); page = BufferGetPage(buffer);