database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-14 18:42:34 +03:00
Code Activity

Fix pg_get_functiondef() to print a function's LEAKPROOF property.

Browse Source 
Seems to have been an oversight in the original leakproofness patch.
Per report and patch from Jeevan Chalke.

In passing, prettify some awkward leakproof-related code in AlterFunction.
This commit is contained in:
Tom Lane
2015-05-28 11:24:37 -04:00
parent 269cb4fbca
commit d4a9f5519d
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/commands/functioncmds.c
View File

@ -1134,11 +1134,11 @@ AlterFunction(AlterFunctionStmt *stmt)
procForm->prosecdef = intVal(security_def_item->arg); procForm->prosecdef = intVal(security_def_item->arg);
if (leakproof_item) if (leakproof_item)
{ {
if (intVal(leakproof_item->arg) && !superuser()) procForm->proleakproof = intVal(leakproof_item->arg);
if (procForm->proleakproof && !superuser())
ereport(ERROR, ereport(ERROR,
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE), (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
errmsg("only superuser can define a leakproof function"))); errmsg("only superuser can define a leakproof function")));
procForm->proleakproof = intVal(leakproof_item->arg);
} }
if (cost_item) if (cost_item)
{ {

2
src/backend/utils/adt/ruleutils.c
View File

@ -1974,6 +1974,8 @@ pg_get_functiondef(PG_FUNCTION_ARGS)
appendStringInfoString(&buf, " STRICT"); appendStringInfoString(&buf, " STRICT");
if (proc->prosecdef) if (proc->prosecdef)
appendStringInfoString(&buf, " SECURITY DEFINER"); appendStringInfoString(&buf, " SECURITY DEFINER");
if (proc->proleakproof)
appendStringInfoString(&buf, " LEAKPROOF");
/* This code for the default cost and rows should match functioncmds.c */ /* This code for the default cost and rows should match functioncmds.c */
if (proc->prolang == INTERNALlanguageId || if (proc->prolang == INTERNALlanguageId ||