From d438515c29c3cc539c79292c040335804183ca3e Mon Sep 17 00:00:00 2001 From: Amit Kapila Date: Thu, 10 Apr 2025 10:23:01 +0530 Subject: [PATCH] Cosmetic fixes for pg_createsubscriber's -all option. Author: Peter Smith Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/CAHut+PsmSCQ-ENSDQ0YOUcsgzT=GG-E9jyXBvxd51A_dMXH5XA@mail.gmail.com --- doc/src/sgml/ref/pg_createsubscriber.sgml | 7 +++++-- src/bin/pg_basebackup/pg_createsubscriber.c | 4 ++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/doc/src/sgml/ref/pg_createsubscriber.sgml b/doc/src/sgml/ref/pg_createsubscriber.sgml index 73377aa6a6e..4b1d08d5f16 100644 --- a/doc/src/sgml/ref/pg_createsubscriber.sgml +++ b/doc/src/sgml/ref/pg_createsubscriber.sgml @@ -94,8 +94,11 @@ PostgreSQL documentation Create one subscription per database on the target server. Exceptions are template databases and databases that don't allow connections. - If the database name is not specified in publisher-server, the postgres - database will be used, or if that does not exist, template1 will be used. + To discover the list of all databases, connect to the source server + using the database name specified in the + connection string, or if not specified, the postgres + database will be used, or if that does not exist, template1 + will be used. Automatically generated names for subscriptions, publications, and replication slots are used when this option is specified. This option cannot be used along with , diff --git a/src/bin/pg_basebackup/pg_createsubscriber.c b/src/bin/pg_basebackup/pg_createsubscriber.c index 1d2f39e3926..42aaa428aed 100644 --- a/src/bin/pg_basebackup/pg_createsubscriber.c +++ b/src/bin/pg_basebackup/pg_createsubscriber.c @@ -1963,8 +1963,8 @@ enable_subscription(PGconn *conn, const struct LogicalRepInfo *dbinfo) } /* - * Fetch a list of all not-template databases from the source server and form - * a list such that they appear as if the user has specified multiple + * Fetch a list of all connectable non-template databases from the source server + * and form a list such that they appear as if the user has specified multiple * --database options, one for each source database. */ static void