database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-19 23:22:23 +03:00
Code Activity

Fix overflow in parsing of positional parameter

Browse Source 
Replace atol with pg_strtoint32_safe in the backend parser and with
strtoint in ECPG to reject overflows when parsing the number of a
positional parameter.  With atol from glibc, parameters $2147483648 and
$4294967297 turn into $-2147483648 and $1, respectively.

Author: Erik Wienhold <ewie@ewie.name>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Reviewed-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/5d216d1c-91f6-4cbe-95e2-b4cbd930520c@ewie.name
This commit is contained in:
Peter Eisentraut
2024-07-02 09:16:36 +02:00
parent 4867f8a555
commit d35cd06199
4 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/parser/scan.l
View File

@@ -992,8 +992,14 @@ other .
}
{param} {
ErrorSaveContext escontext = {T_ErrorSaveContext};
int32 val;
SET_YYLLOC();
yylval->ival = atol(yytext + 1);
val = pg_strtoint32_safe(yytext + 1, (Node *) &escontext);
if (escontext.error_occurred)
yyerror("parameter number too large");
yylval->ival = val;
return PARAM;
}
{param_junk} {