From d26b042ce577a4012b9798528f0b1bcfa6e502eb Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 22 Apr 2014 23:22:12 -0400 Subject: [PATCH] Fix documentation of FmgrInfo.fn_nargs. Some ancient comments claimed that fn_nargs could be -1 to indicate a variable number of input arguments; but this was never implemented, and is at variance with what we ultimately did with "variadic" functions. Update the comments. --- src/backend/utils/fmgr/README | 2 +- src/include/fmgr.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/backend/utils/fmgr/README b/src/backend/utils/fmgr/README index a650eb14a37..e7e7ae9c6e8 100644 --- a/src/backend/utils/fmgr/README +++ b/src/backend/utils/fmgr/README @@ -67,7 +67,7 @@ typedef struct { PGFunction fn_addr; /* pointer to function or handler to be called */ Oid fn_oid; /* OID of function (NOT of handler, if any) */ - short fn_nargs; /* 0..FUNC_MAX_ARGS, or -1 if variable arg count */ + short fn_nargs; /* number of input args (0..FUNC_MAX_ARGS) */ bool fn_strict; /* function is "strict" (NULL in => NULL out) */ bool fn_retset; /* function returns a set (over multiple calls) */ unsigned char fn_stats; /* collect stats if track_functions > this */ diff --git a/src/include/fmgr.h b/src/include/fmgr.h index 494c768826b..22539eecb60 100644 --- a/src/include/fmgr.h +++ b/src/include/fmgr.h @@ -54,8 +54,7 @@ typedef struct FmgrInfo { PGFunction fn_addr; /* pointer to function or handler to be called */ Oid fn_oid; /* OID of function (NOT of handler, if any) */ - short fn_nargs; /* 0..FUNC_MAX_ARGS, or -1 if variable arg - * count */ + short fn_nargs; /* number of input args (0..FUNC_MAX_ARGS) */ bool fn_strict; /* function is "strict" (NULL in => NULL out) */ bool fn_retset; /* function returns a set */ unsigned char fn_stats; /* collect stats if track_functions > this */