database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

Rename PQtraceSetFlags() to PQsetTraceFlags().

Browse Source 
We have a dozen PQset*() functions.  PQresultSetInstanceData() and this
were the libpq setter functions having a different word order.  Adopt
the majority word order.

Reviewed by Alvaro Herrera and Robert Haas, though this choice of name
was not unanimous.

Discussion: https://postgr.es/m/20210605060555.GA216695@rfd.leadboat.com
This commit is contained in:
Noah Misch
2021-06-10 21:56:13 -07:00
parent 04539e73fa
commit d0e750c0ac
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
doc/src/sgml/libpq.sgml
View File

@ -6533,14 +6533,14 @@ void PQtrace(PGconn *conn, FILE *stream);
</listitem> </listitem>
</varlistentry> </varlistentry>
<varlistentry id="libpq-PQtraceSetFlags"> <varlistentry id="libpq-PQsetTraceFlags">
<term><function>PQtraceSetFlags</function><indexterm><primary>PQtraceSetFlags</primary></indexterm></term> <term><function>PQsetTraceFlags</function><indexterm><primary>PQtraceSetFlags</primary></indexterm></term>
<listitem> <listitem>
<para> <para>
Controls the tracing behavior of client/server communication. Controls the tracing behavior of client/server communication.
<synopsis> <synopsis>
void PQtraceSetFlags(PGconn *conn, int flags); void PQsetTraceFlags(PGconn *conn, int flags);
</synopsis> </synopsis>
</para> </para>

2
src/interfaces/libpq/exports.txt
View File

@ -183,5 +183,5 @@ PQenterPipelineMode 180
PQexitPipelineMode 181 PQexitPipelineMode 181
PQpipelineSync 182 PQpipelineSync 182
PQpipelineStatus 183 PQpipelineStatus 183
PQtraceSetFlags 184 PQsetTraceFlags 184
PQmblenBounded 185 PQmblenBounded 185

2
src/interfaces/libpq/fe-trace.c
View File

@ -61,7 +61,7 @@ PQuntrace(PGconn *conn)
/* Set flags for current tracing session */ /* Set flags for current tracing session */
void void
PQtraceSetFlags(PGconn *conn, int flags) PQsetTraceFlags(PGconn *conn, int flags)
{ {
if (conn == NULL) if (conn == NULL)
return; return;

2
src/interfaces/libpq/libpq-fe.h
View File

@ -403,7 +403,7 @@ extern void PQuntrace(PGconn *conn);
#define PQTRACE_SUPPRESS_TIMESTAMPS (1<<0) #define PQTRACE_SUPPRESS_TIMESTAMPS (1<<0)
/* redact portions of some messages, for testing frameworks */ /* redact portions of some messages, for testing frameworks */
#define PQTRACE_REGRESS_MODE (1<<1) #define PQTRACE_REGRESS_MODE (1<<1)
extern void PQtraceSetFlags(PGconn *conn, int flags); extern void PQsetTraceFlags(PGconn *conn, int flags);
/* === in fe-exec.c === */ /* === in fe-exec.c === */

2
src/test/modules/libpq_pipeline/libpq_pipeline.c
View File

@ -1326,7 +1326,7 @@ main(int argc, char **argv)
setvbuf(trace, NULL, PG_IOLBF, 0); setvbuf(trace, NULL, PG_IOLBF, 0);
PQtrace(conn, trace); PQtrace(conn, trace);
PQtraceSetFlags(conn, PQsetTraceFlags(conn,
PQTRACE_SUPPRESS_TIMESTAMPS | PQTRACE_REGRESS_MODE); PQTRACE_SUPPRESS_TIMESTAMPS | PQTRACE_REGRESS_MODE);
} }