database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-19 23:22:23 +03:00
Code Activity

Remove unnecessary checks for indexes for REPLICA IDENTITY FULL tables.

Browse Source 
Previously, when selecting an usable index for update/delete for the
REPLICA IDENTITY FULL table, in IsIndexOnlyExpression(), we used to
check if all index fields are not expressions. However, it was not
necessary, because it is enough to check if only the leftmost index
field is not an expression (and references the remote table column)
and this check has already been done by
RemoteRelContainsLeftMostColumnOnIdx().

This commit removes IsIndexOnlyExpression() and
RemoteRelContainsLeftMostColumnOnIdx() and all checks for usable
indexes for REPLICA IDENTITY FULL tables are now performed by
IsIndexUsableForReplicaIdentityFull().

Backpatch this to remain the code consistent.

Reported-by: Peter Smith
Reviewed-by: Amit Kapila, Önder Kalacı
Discussion: https://postgr.es/m/CAHut%2BPsGRE5WSsY0jcLHJEoA17MrbP9yy8FxdjC_ZOAACxbt%2BQ%40mail.gmail.com
Backpatch-through: 16
This commit is contained in:
Masahiko Sawada
2023-07-25 15:09:34 +09:00
parent 71e4cc6b8e
commit d0ce9d0bc7
4 changed files with 64 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/executor/execReplication.c
View File

@@ -222,16 +222,7 @@ retry:
if (!isIdxSafeToSkipDuplicates)
{
if (eq == NULL)
{
#ifdef USE_ASSERT_CHECKING
/* apply assertions only once for the input idxoid */
IndexInfo *indexInfo = BuildIndexInfo(idxrel);
Assert(IsIndexUsableForReplicaIdentityFull(indexInfo));
#endif
eq = palloc0(sizeof(*eq) * outslot->tts_tupleDescriptor->natts);
}
if (!tuples_equal(outslot, searchslot, eq))
continue;