database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-09-06 13:46:51 +03:00
Code Activity

Remove the option to service interrupts during PGSemaphoreLock().

Browse Source 
The remaining caller (lwlocks) doesn't need that facility, and we plan
to remove ImmedidateInterruptOK entirely. That means that interrupts
can't be serviced race-free and portably anyway, so there's little
reason for keeping the feature.

Reviewed-By: Heikki Linnakangas
This commit is contained in:
Andres Freund
2015-02-03 23:25:00 +01:00
parent 6753333f55
commit d06995710b
5 changed files with 12 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/storage/lmgr/lwlock.c
View File

@@ -863,8 +863,7 @@ LWLockDequeueSelf(LWLock *lock)
*/
for (;;)
{
/* "false" means cannot accept cancel/die interrupt here. */
PGSemaphoreLock(&MyProc->sem, false);
PGSemaphoreLock(&MyProc->sem);
if (!MyProc->lwWaiting)
break;
extraWaits++;
@@ -1034,8 +1033,7 @@ LWLockAcquireCommon(LWLock *lock, LWLockMode mode, uint64 *valptr, uint64 val)
for (;;)
{
/* "false" means cannot accept cancel/die interrupt here. */
PGSemaphoreLock(&proc->sem, false);
PGSemaphoreLock(&proc->sem);
if (!proc->lwWaiting)
break;
extraWaits++;
@@ -1195,8 +1193,7 @@ LWLockAcquireOrWait(LWLock *lock, LWLockMode mode)
for (;;)
{
/* "false" means cannot accept cancel/die interrupt here. */
PGSemaphoreLock(&proc->sem, false);
PGSemaphoreLock(&proc->sem);
if (!proc->lwWaiting)
break;
extraWaits++;
@@ -1397,8 +1394,7 @@ LWLockWaitForVar(LWLock *lock, uint64 *valptr, uint64 oldval, uint64 *newval)
for (;;)
{
/* "false" means cannot accept cancel/die interrupt here. */
PGSemaphoreLock(&proc->sem, false);
PGSemaphoreLock(&proc->sem);
if (!proc->lwWaiting)
break;
extraWaits++;