From cec5fe0d1e192b3b0005063011f113ac99f6908c Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 21 Jan 2026 13:26:19 -0500 Subject: [PATCH] Remove useless flag PVC_INCLUDE_CONVERTROWTYPES. This was introduced in the SJE patch (fc069a3a6), but it doesn't do anything because pull_var_clause() never tests it. Apparently it snuck in from somebody's private fork. Remove it again, but only in HEAD -- seems best to let it be in v18. Author: Alexander Pyhalov Reviewed-by: Tom Lane Discussion: https://postgr.es/m/70008c19d22e3dd1565ca57f8436c0ba@postgrespro.ru --- src/backend/optimizer/path/equivclass.c | 3 +-- src/include/optimizer/optimizer.h | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/backend/optimizer/path/equivclass.c b/src/backend/optimizer/path/equivclass.c index a4fcfcc86c8..e3697df51a2 100644 --- a/src/backend/optimizer/path/equivclass.c +++ b/src/backend/optimizer/path/equivclass.c @@ -1007,8 +1007,7 @@ find_computable_ec_member(PlannerInfo *root, exprvars = pull_var_clause((Node *) exprs, PVC_INCLUDE_AGGREGATES | PVC_INCLUDE_WINDOWFUNCS | - PVC_INCLUDE_PLACEHOLDERS | - PVC_INCLUDE_CONVERTROWTYPES); + PVC_INCLUDE_PLACEHOLDERS); setup_eclass_member_iterator(&it, ec, relids); while ((em = eclass_member_iterator_next(&it)) != NULL) diff --git a/src/include/optimizer/optimizer.h b/src/include/optimizer/optimizer.h index 485f641b3b4..3d27a019609 100644 --- a/src/include/optimizer/optimizer.h +++ b/src/include/optimizer/optimizer.h @@ -193,8 +193,6 @@ extern SortGroupClause *get_sortgroupref_clause_noerr(Index sortref, * output list */ #define PVC_RECURSE_PLACEHOLDERS 0x0020 /* recurse into PlaceHolderVar * arguments */ -#define PVC_INCLUDE_CONVERTROWTYPES 0x0040 /* include ConvertRowtypeExprs in - * output list */ extern Bitmapset *pull_varnos(PlannerInfo *root, Node *node); extern Bitmapset *pull_varnos_of_level(PlannerInfo *root, Node *node, int levelsup);