From ce47112b6a91a39b0dd9295c046d31dd7ec50fb8 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Thu, 14 Apr 2016 12:18:09 -0400 Subject: [PATCH] Adjust datatype of ReplicationState.acquired_by. It was declared as "pid_t", which would be fine except that none of the places that printed it in error messages took any thought for the possibility that it's not equivalent to "int". This leads to warnings on some buildfarm members, and could possibly lead to actually wrong error messages on those platforms. There doesn't seem to be any very good reason not to just make it "int"; it's only ever assigned from MyProcPid, which is int. If we want to cope with PIDs that are wider than int, this is not the place to start. Also, fix the comment, which seems to perhaps be a leftover from a time when the field was only a bool? Per buildfarm. Back-patch to 9.5 which has same issue. --- src/backend/replication/logical/origin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/replication/logical/origin.c b/src/backend/replication/logical/origin.c index 6f96ce7255e..ca90e9ea376 100644 --- a/src/backend/replication/logical/origin.c +++ b/src/backend/replication/logical/origin.c @@ -120,9 +120,9 @@ typedef struct ReplicationState XLogRecPtr local_lsn; /* - * Slot is setup in backend? + * PID of backend that's acquired slot, or 0 if none. */ - pid_t acquired_by; + int acquired_by; /* * Lock protecting remote_lsn and local_lsn.