database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-22 23:02:54 +03:00
Code

Remove -w (--ignore-all-space) option from pg_regress's diff calls.

Browse Source 
We have used -w for a long time as a means of reducing the reported diff
volume when one element of a result table isn't of the expected width.
However, most of the time the results just pass anyway, so this isn't as
important as it once was.  Meanwhile, the risk of missing potentially
significant deviations has gone up, particularly with psql's ability to
report error cursor positions.  So, let's switch over to space-sensitive
comparisons.  Per my proposal of yesterday.

(All the expected files that I can test here seem to be ready for this
already, but we'll see what the buildfarm thinks about others.)
This commit is contained in:
Tom Lane 2009-11-22 17:54:23 +00:00
parent 997a6a278f
commit ce3153fa93
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/regress/pg_regress.c
View File

@ -11,7 +11,7 @@
* Portions Copyright (c) 1996-2009, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2009, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* $PostgreSQL: pgsql/src/test/regress/pg_regress.c,v 1.65 2009/11/14 15:39:36 mha Exp $ * $PostgreSQL: pgsql/src/test/regress/pg_regress.c,v 1.66 2009/11/22 17:54:23 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -66,8 +66,8 @@ static char *shellprog = SHELLPROG;
#endif #endif
/* currently we can use the same diff switches on all platforms */ /* currently we can use the same diff switches on all platforms */
const char *basic_diff_opts = "-w"; const char *basic_diff_opts = "";
const char *pretty_diff_opts = "-w -C3"; const char *pretty_diff_opts = "-C3";
/* options settable from command line */ /* options settable from command line */
_stringlist *dblist = NULL; _stringlist *dblist = NULL;