From cdd863480c27b406ac14e94f1fe122b98ea562b4 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Tue, 23 Jan 2024 10:45:00 +0900 Subject: [PATCH] Fix ERROR message in injection_point.c This commit fixes an error message that failed to show the correct function and library names when a function cannot be loaded. While on it, adjust the call to load_external_function() so as this ERROR can be reached, by making load_external_function() return NULL rather than fail if a function cannot be found for a given injection point. Thinkos in d86d20f0ba79. --- src/backend/utils/misc/injection_point.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/utils/misc/injection_point.c b/src/backend/utils/misc/injection_point.c index 4f52f198533..0cf4d51cac4 100644 --- a/src/backend/utils/misc/injection_point.c +++ b/src/backend/utils/misc/injection_point.c @@ -300,11 +300,11 @@ InjectionPointRun(const char *name) path, name); injection_callback = (InjectionPointCallback) - load_external_function(path, entry_by_name->function, true, NULL); + load_external_function(path, entry_by_name->function, false, NULL); if (injection_callback == NULL) elog(ERROR, "could not find function \"%s\" in library \"%s\" for injection point \"%s\"", - name, entry_by_name->function, path); + entry_by_name->function, path, name); /* add it to the local cache when found */ injection_point_cache_add(name, injection_callback);