database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-07 00:36:50 +03:00
Code Activity

Fix background workers for EXEC_BACKEND

Browse Source 
Commit da07a1e8 was broken for EXEC_BACKEND because I failed to realize
that the MaxBackends recomputation needed to be duplicated by
subprocesses in SubPostmasterMain.  However, instead of having the value
be recomputed at all, it's better to assign the correct value at
postmaster initialization time, and have it be propagated to exec'ed
backends via BackendParameters.

MaxBackends stays as zero until after modules in
shared_preload_libraries have had a chance to register bgworkers, since
the value is going to be untrustworthy till that's finished.

Heikki Linnakangas and Álvaro Herrera
This commit is contained in:
Alvaro Herrera
2013-01-02 12:01:14 -03:00
parent d194d7a526
commit cdbc0ca48c
4 changed files with 52 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/backend/utils/misc/guc.c
View File

@ -103,17 +103,6 @@
#define MAX_KILOBYTES (INT_MAX / 1024)
#endif
/*
* Note: MAX_BACKENDS is limited to 2^23-1 because inval.c stores the
* backend ID as a 3-byte signed integer. Even if that limitation were
* removed, we still could not exceed INT_MAX/4 because some places compute
* 4*MaxBackends without any overflow check. This is rechecked in
* check_maxconnections, since MaxBackends is computed as MaxConnections
* plus the number of bgworkers plus autovacuum_max_workers plus one (for the
* autovacuum launcher).
*/
#define MAX_BACKENDS 0x7fffff
#define KB_PER_MB (1024)
#define KB_PER_GB (1024*1024)
@ -199,9 +188,7 @@ static const char *show_tcp_keepalives_idle(void);
static const char *show_tcp_keepalives_interval(void);
static const char *show_tcp_keepalives_count(void);
static bool check_maxconnections(int *newval, void **extra, GucSource source);
static void assign_maxconnections(int newval, void *extra);
static bool check_autovacuum_max_workers(int *newval, void **extra, GucSource source);
static void assign_autovacuum_max_workers(int newval, void *extra);
static bool check_effective_io_concurrency(int *newval, void **extra, GucSource source);
static void assign_effective_io_concurrency(int newval, void *extra);
static void assign_pgstat_temp_directory(const char *newval, void *extra);
@ -1615,7 +1602,7 @@ static struct config_int ConfigureNamesInt[] =
},
&MaxConnections,
100, 1, MAX_BACKENDS,
check_maxconnections, assign_maxconnections, NULL
check_maxconnections, NULL, NULL
},
{
@ -2290,7 +2277,7 @@ static struct config_int ConfigureNamesInt[] =
},
&autovacuum_max_workers,
3, 1, MAX_BACKENDS,
check_autovacuum_max_workers, assign_autovacuum_max_workers, NULL
check_autovacuum_max_workers, NULL, NULL
},
{
@ -8636,13 +8623,6 @@ check_maxconnections(int *newval, void **extra, GucSource source)
return true;
}
static void
assign_maxconnections(int newval, void *extra)
{
MaxBackends = newval + autovacuum_max_workers + 1 +
GetNumShmemAttachedBgworkers();
}
static bool
check_autovacuum_max_workers(int *newval, void **extra, GucSource source)
{
@ -8652,12 +8632,6 @@ check_autovacuum_max_workers(int *newval, void **extra, GucSource source)
return true;
}
static void
assign_autovacuum_max_workers(int newval, void *extra)
{
MaxBackends = MaxConnections + newval + 1 + GetNumShmemAttachedBgworkers();
}
static bool
check_effective_io_concurrency(int *newval, void **extra, GucSource source)
{