database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

XLogRegisterData, XLogRegisterBufData void * argument for binary data

Browse Source 
Change XLogRegisterData() and XLogRegisterBufData() functions to take
void * for binary data instead of char *.  This will remove the need
for numerous casts (done in a separate commit for clarity).

Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Discussion: https://www.postgresql.org/message-id/flat/fd1fcedb-3492-4fc8-9e3e-74b97f2db6c7%40eisentraut.org
This commit is contained in:
Peter Eisentraut
2025-02-13 10:33:14 +01:00
parent 773c51dd39
commit cdaeff9b39
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/access/transam/README
View File

@ -586,13 +586,13 @@ void XLogRegisterBuffer(uint8 block_id, Buffer buf, uint8 flags);
XLogRegisterBufData() is included in the WAL record even if a full-page
image is taken.
void XLogRegisterData(const char *data, int len);
void XLogRegisterData(const void *data, int len);
XLogRegisterData is used to include arbitrary data in the WAL record. If
XLogRegisterData() is called multiple times, the data are appended, and
will be made available to the redo routine as one contiguous chunk.
void XLogRegisterBufData(uint8 block_id, const char *data, int len);
void XLogRegisterBufData(uint8 block_id, const void *data, int len);
XLogRegisterBufData is used to include data associated with a particular
buffer that was registered earlier with XLogRegisterBuffer(). If

4
src/backend/access/transam/xloginsert.c
View File

@ -361,7 +361,7 @@ XLogRegisterBlock(uint8 block_id, RelFileLocator *rlocator, ForkNumber forknum,
* XLogRecGetData().
*/
void
XLogRegisterData(const char *data, uint32 len)
XLogRegisterData(const void *data, uint32 len)
{
XLogRecData *rdata;
@ -402,7 +402,7 @@ XLogRegisterData(const char *data, uint32 len)
* limited)
*/
void
XLogRegisterBufData(uint8 block_id, const char *data, uint32 len)
XLogRegisterBufData(uint8 block_id, const void *data, uint32 len)
{
registered_buffer *regbuf;
XLogRecData *rdata;

2
src/include/access/xlog_internal.h
View File

@ -312,7 +312,7 @@ typedef struct xl_end_of_recovery
typedef struct XLogRecData
{
struct XLogRecData *next; /* next struct in chain, or NULL */
const char *data; /* start of rmgr data to include */
const void *data; /* start of rmgr data to include */
uint32 len; /* length of rmgr data to include */
} XLogRecData;

4
src/include/access/xloginsert.h
View File

@ -45,12 +45,12 @@ extern void XLogBeginInsert(void);
extern void XLogSetRecordFlags(uint8 flags);
extern XLogRecPtr XLogInsert(RmgrId rmid, uint8 info);
extern void XLogEnsureRecordSpace(int max_block_id, int ndatas);
extern void XLogRegisterData(const char *data, uint32 len);
extern void XLogRegisterData(const void *data, uint32 len);
extern void XLogRegisterBuffer(uint8 block_id, Buffer buffer, uint8 flags);
extern void XLogRegisterBlock(uint8 block_id, RelFileLocator *rlocator,
ForkNumber forknum, BlockNumber blknum, const PageData *page,
uint8 flags);
extern void XLogRegisterBufData(uint8 block_id, const char *data, uint32 len);
extern void XLogRegisterBufData(uint8 block_id, const void *data, uint32 len);
extern void XLogResetInsertion(void);
extern bool XLogCheckBufferNeedsBackup(Buffer buffer);