database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-12 21:01:52 +03:00
Code Activity

Suppress maybe-uninitialized compiler warnings.

Browse Source 
Previously some compilers were thinking that the variables that
57aa5b2 added maybe-uninitialized.

Spotted by Andres Freund
This commit is contained in:
Fujii Masao
2015-03-15 10:40:43 +09:00
parent 5ff683962e
commit cd6c45cbee
1 changed files with 18 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/backend/access/transam/xloginsert.c
View File

@ -491,11 +491,9 @@ XLogRecordAssemble(RmgrId rmid, uint8 info,
bool needs_data; bool needs_data;
XLogRecordBlockHeader bkpb; XLogRecordBlockHeader bkpb;
XLogRecordBlockImageHeader bimg; XLogRecordBlockImageHeader bimg;
XLogRecordBlockCompressHeader cbimg; XLogRecordBlockCompressHeader cbimg = {0};
bool samerel; bool samerel;
bool is_compressed = false; bool is_compressed = false;
uint16 hole_length;
uint16 hole_offset;
if (!regbuf->in_use) if (!regbuf->in_use)
continue; continue;
@ -558,21 +556,21 @@ XLogRecordAssemble(RmgrId rmid, uint8 info,
upper > lower && upper > lower &&
upper <= BLCKSZ) upper <= BLCKSZ)
{ {
hole_offset = lower; bimg.hole_offset = lower;
hole_length = upper - lower; cbimg.hole_length = upper - lower;
} }
else else
{ {
/* No "hole" to compress out */ /* No "hole" to compress out */
hole_offset = 0; bimg.hole_offset = 0;
hole_length = 0; cbimg.hole_length = 0;
} }
} }
else else
{ {
/* Not a standard page header, don't try to eliminate "hole" */ /* Not a standard page header, don't try to eliminate "hole" */
hole_offset = 0; bimg.hole_offset = 0;
hole_length = 0; cbimg.hole_length = 0;
} }
/* /*
@ -581,7 +579,8 @@ XLogRecordAssemble(RmgrId rmid, uint8 info,
if (wal_compression) if (wal_compression)
{ {
is_compressed = is_compressed =
XLogCompressBackupBlock(page, hole_offset, hole_length, XLogCompressBackupBlock(page, bimg.hole_offset,
cbimg.hole_length,
regbuf->compressed_page, regbuf->compressed_page,
&compressed_len); &compressed_len);
} }
@ -595,25 +594,21 @@ XLogRecordAssemble(RmgrId rmid, uint8 info,
rdt_datas_last->next = &regbuf->bkp_rdatas[0]; rdt_datas_last->next = &regbuf->bkp_rdatas[0];
rdt_datas_last = rdt_datas_last->next; rdt_datas_last = rdt_datas_last->next;
bimg.bimg_info = (hole_length == 0) ? 0 : BKPIMAGE_HAS_HOLE; bimg.bimg_info = (cbimg.hole_length == 0) ? 0 : BKPIMAGE_HAS_HOLE;
if (is_compressed) if (is_compressed)
{ {
bimg.length = compressed_len; bimg.length = compressed_len;
bimg.hole_offset = hole_offset;
bimg.bimg_info |= BKPIMAGE_IS_COMPRESSED; bimg.bimg_info |= BKPIMAGE_IS_COMPRESSED;
if (hole_length != 0)
cbimg.hole_length = hole_length;
rdt_datas_last->data = regbuf->compressed_page; rdt_datas_last->data = regbuf->compressed_page;
rdt_datas_last->len = compressed_len; rdt_datas_last->len = compressed_len;
} }
else else
{ {
bimg.length = BLCKSZ - hole_length; bimg.length = BLCKSZ - cbimg.hole_length;
bimg.hole_offset = hole_offset;
if (hole_length == 0) if (cbimg.hole_length == 0)
{ {
rdt_datas_last->data = page; rdt_datas_last->data = page;
rdt_datas_last->len = BLCKSZ; rdt_datas_last->len = BLCKSZ;
@ -622,13 +617,15 @@ XLogRecordAssemble(RmgrId rmid, uint8 info,
{ {
/* must skip the hole */ /* must skip the hole */
rdt_datas_last->data = page; rdt_datas_last->data = page;
rdt_datas_last->len = hole_offset; rdt_datas_last->len = bimg.hole_offset;
rdt_datas_last->next = &regbuf->bkp_rdatas[1]; rdt_datas_last->next = &regbuf->bkp_rdatas[1];
rdt_datas_last = rdt_datas_last->next; rdt_datas_last = rdt_datas_last->next;
rdt_datas_last->data = page + (hole_offset + hole_length); rdt_datas_last->data =
rdt_datas_last->len = BLCKSZ - (hole_offset + hole_length); page + (bimg.hole_offset + cbimg.hole_length);
rdt_datas_last->len =
BLCKSZ - (bimg.hole_offset + cbimg.hole_length);
} }
} }
@ -665,7 +662,7 @@ XLogRecordAssemble(RmgrId rmid, uint8 info,
{ {
memcpy(scratch, &bimg, SizeOfXLogRecordBlockImageHeader); memcpy(scratch, &bimg, SizeOfXLogRecordBlockImageHeader);
scratch += SizeOfXLogRecordBlockImageHeader; scratch += SizeOfXLogRecordBlockImageHeader;
if (hole_length != 0 && is_compressed) if (cbimg.hole_length != 0 && is_compressed)
{ {
memcpy(scratch, &cbimg, memcpy(scratch, &cbimg,
SizeOfXLogRecordBlockCompressHeader); SizeOfXLogRecordBlockCompressHeader);