database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-13 14:22:43 +03:00
Code Activity

Defend against possible crash if a plpython function does not specify names

Browse Source 
for its arguments.  Also add a regression test, since someone apparently
changed every single plpython test case to use only named parameters; else
we'd have noticed this sooner.

Euler Taveira de Oliveira, per a report from Alvaro
This commit is contained in:
Tom Lane
2009-04-03 16:59:43 +00:00
parent aa38153d22
commit cd331e4b84
5 changed files with 26 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pl/plpython/sql/plpython_function.sql
View File

@@ -391,8 +391,12 @@ $$ LANGUAGE plpythonu;
--
-- Test named parameters
-- Test named and nameless parameters
--
CREATE FUNCTION test_param_names0(integer, integer) RETURNS int AS $$
return args[0] + args[1]
$$ LANGUAGE plpythonu;
CREATE FUNCTION test_param_names1(a0 integer, a1 text) RETURNS boolean AS $$
assert a0 == args[0]
assert a1 == args[1]

3
src/pl/plpython/sql/plpython_test.sql
View File

@@ -74,7 +74,8 @@ SELECT test_void_func1(), test_void_func1() IS NULL AS "is null";
SELECT test_void_func2(); -- should fail
SELECT test_return_none(), test_return_none() IS NULL AS "is null";
-- Test for functions with named parameters
-- Test for functions with named and nameless parameters
SELECT test_param_names0(2,7);
SELECT test_param_names1(1,'text');
SELECT test_param_names2(users) from users;
SELECT test_param_names3(1);