From cc1ea710dc88186aab4b3c129883d710781fcfb6 Mon Sep 17 00:00:00 2001 From: Amit Kapila Date: Wed, 12 Aug 2026 11:28:30 +0530 Subject: [PATCH] Remove unnecessary list_free() calls in OpenTableList(). OpenTableList() is invoked at most once per DDL statement, from CreatePublication() and AlterPublicationTables(), and everything it builds (relids, relids_with_rf, and relids_with_collist) is allocated in the command's own memory context. That context is reclaimed as soon as the command finishes, so explicitly freeing relids and relids_with_rf here served no purpose. Reported-by: Peter Smith Suggested-by: Tom Lane Author: Peter Smith Reviewed-by: shveta malik Reviewed-by: shihao zhong Reviewed-by: surya poondla Discussion: https://postgr.es/m/CAHut+Pt3bgyt==d6GCj=p9qu4sVSH_KQWLN7cMaH0RdJCO-K_Q@mail.gmail.com --- src/backend/commands/publicationcmds.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/backend/commands/publicationcmds.c b/src/backend/commands/publicationcmds.c index 440adb356ad..96838730fe1 100644 --- a/src/backend/commands/publicationcmds.c +++ b/src/backend/commands/publicationcmds.c @@ -1977,9 +1977,6 @@ OpenTableList(List *tables) } } - list_free(relids); - list_free(relids_with_rf); - return rels; }