database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-17 06:41:09 +03:00
Code Activity

Remove useless casts

Browse Source 
Casting the argument of strVal() to (Value *) is useless, since
strVal() already does that.

Most code didn't do that anyway; this was apparently just a style that
snuck into certain files.

Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/5ba6bc5b-3f95-04f2-2419-f8ddb4c046fb@enterprisedb.com
This commit is contained in:
Peter Eisentraut
2021-09-09 07:58:12 +02:00
parent 3b231596cc
commit cbdf75bf80
5 changed files with 28 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/backend/commands/alter.c
View File

@ -501,7 +501,7 @@ ExecAlterObjectSchemaStmt(AlterObjectSchemaStmt *stmt,
switch (stmt->objectType)
{
case OBJECT_EXTENSION:
address = AlterExtensionNamespace(strVal((Value *) stmt->object), stmt->newschema,
address = AlterExtensionNamespace(strVal(stmt->object), stmt->newschema,
oldSchemaAddr ? &oldNspOid : NULL);
break;
@ -837,10 +837,10 @@ ExecAlterOwnerStmt(AlterOwnerStmt *stmt)
switch (stmt->objectType)
{
case OBJECT_DATABASE:
return AlterDatabaseOwner(strVal((Value *) stmt->object), newowner);
return AlterDatabaseOwner(strVal(stmt->object), newowner);
case OBJECT_SCHEMA:
return AlterSchemaOwner(strVal((Value *) stmt->object), newowner);
return AlterSchemaOwner(strVal(stmt->object), newowner);
case OBJECT_TYPE:
case OBJECT_DOMAIN: /* same as TYPE */
@ -848,23 +848,23 @@ ExecAlterOwnerStmt(AlterOwnerStmt *stmt)
break;
case OBJECT_FDW:
return AlterForeignDataWrapperOwner(strVal((Value *) stmt->object),
return AlterForeignDataWrapperOwner(strVal(stmt->object),
newowner);
case OBJECT_FOREIGN_SERVER:
return AlterForeignServerOwner(strVal((Value *) stmt->object),
return AlterForeignServerOwner(strVal(stmt->object),
newowner);
case OBJECT_EVENT_TRIGGER:
return AlterEventTriggerOwner(strVal((Value *) stmt->object),
return AlterEventTriggerOwner(strVal(stmt->object),
newowner);
case OBJECT_PUBLICATION:
return AlterPublicationOwner(strVal((Value *) stmt->object),
return AlterPublicationOwner(strVal(stmt->object),
newowner);
case OBJECT_SUBSCRIPTION:
return AlterSubscriptionOwner(strVal((Value *) stmt->object),
return AlterSubscriptionOwner(strVal(stmt->object),
newowner);
/* Generic cases */