database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-23 03:21:12 +03:00
Code Activity

Silence compiler warnings

Browse Source 
Rearrange a bit of code to ensure that 'mode' in LWLockRelease is
obviously always set, which seems a bit cleaner and avoids a compiler
warning (thanks to Robert for the suggestion!).

Back-patch back to 9.5 where the warning is first seen.

Author: Stephen Frost
Discussion: https://postgr.es/m/20161129152102.GR13284%40tamriel.snowman.net
This commit is contained in:
Joe Conway
2017-01-02 14:42:44 -08:00
parent 35d4dd82c2
commit cbc62b2295
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/storage/lmgr/lwlock.c
View File

@ -1533,15 +1533,14 @@ LWLockRelease(LWLock *lock)
* be the latest-acquired lock; so search array backwards. * be the latest-acquired lock; so search array backwards.
*/ */
for (i = num_held_lwlocks; --i >= 0;) for (i = num_held_lwlocks; --i >= 0;)
{
if (lock == held_lwlocks[i].lock) if (lock == held_lwlocks[i].lock)
{
mode = held_lwlocks[i].mode;
break; break;
}
}
if (i < 0) if (i < 0)
elog(ERROR, "lock %s %d is not held", T_NAME(lock), T_ID(lock)); elog(ERROR, "lock %s %d is not held", T_NAME(lock), T_ID(lock));
mode = held_lwlocks[i].mode;
num_held_lwlocks--; num_held_lwlocks--;
for (; i < num_held_lwlocks; i++) for (; i < num_held_lwlocks; i++)
held_lwlocks[i] = held_lwlocks[i + 1]; held_lwlocks[i] = held_lwlocks[i + 1];