mirror of
https://github.com/postgres/postgres.git
synced 2025-06-11 20:28:21 +03:00
Increase DEFAULT_FDW_TUPLE_COST from 0.01 to 0.2
0.01 was unrealistically low as it's the same as the default cpu_tuple_cost and 10x cheaper than the default parallel_tuple_cost. It's hard to imagine a situation where fetching a tuple from a foreign server would be cheaper than fetching one from a parallel worker. After some experimentation on a loopback server, somewhere between 0.15 and 0.3 seems more realistic. Here we split the difference and set it to 0.2. This will cause operations that reduce the number of tuples (e.g. aggregation) to be more likely to take place on the foreign server. Adjusting this causes some plan changes in the postgres_fdw regression tests. This is because penalizing each Path with the additional tuple costs causes some dilution of the costs of the other operations being charged for and results in various paths appearing to be closer to the same costs such that add_path's STD_FUZZ_FACTOR is more likely to see two paths as costing (fuzzily) the same. This isn't ideal, but it shouldn't be reason enough to use artificially low costs. Discussion: https://postgr.es/m/CAApHDvopVjjfh5c1Ed2HRvDdfom2dEpMwwiu5-f1AnmYprJngA@mail.gmail.com
This commit is contained in:
@ -57,7 +57,7 @@ PG_MODULE_MAGIC;
|
||||
#define DEFAULT_FDW_STARTUP_COST 100.0
|
||||
|
||||
/* Default CPU cost to process 1 row (above and beyond cpu_tuple_cost). */
|
||||
#define DEFAULT_FDW_TUPLE_COST 0.01
|
||||
#define DEFAULT_FDW_TUPLE_COST 0.2
|
||||
|
||||
/* If no remote estimates, assume a sort costs 20% extra */
|
||||
#define DEFAULT_FDW_SORT_MULTIPLIER 1.2
|
||||
|
Reference in New Issue
Block a user