mirror of
https://github.com/postgres/postgres.git
synced 2025-08-25 20:23:07 +03:00
ReadNewTransactionId() -> ReadNextTransactionId().
The new name conveys the effect better, is more consistent with similar functions ReadNextMultiXactId(), ReadNextFullTransactionId(), and matches the name of the variable that it reads. Reported-by: Peter Geoghegan <pg@bowt.ie> Discussion: https://postgr.es/m/CAH2-WzmVR4SakBXQUdhhPpMf1aYvZCnna5%3DHKa7DAgEmBAg%2B8g%40mail.gmail.com
This commit is contained in:
@@ -189,7 +189,7 @@ ginDeletePage(GinVacuumState *gvs, BlockNumber deleteBlkno, BlockNumber leftBlkn
|
||||
* address.
|
||||
*/
|
||||
GinPageSetDeleted(page);
|
||||
GinPageSetDeleteXid(page, ReadNewTransactionId());
|
||||
GinPageSetDeleteXid(page, ReadNextTransactionId());
|
||||
|
||||
MarkBufferDirty(pBuffer);
|
||||
MarkBufferDirty(lBuffer);
|
||||
|
@@ -2266,7 +2266,7 @@ _bt_mark_page_halfdead(Relation rel, Buffer leafbuf, BTStack stack)
|
||||
*
|
||||
* We maintain *oldestBtpoXact for pages that are deleted by the current
|
||||
* VACUUM operation here. This must be handled here because we conservatively
|
||||
* assume that there needs to be a new call to ReadNewTransactionId() each
|
||||
* assume that there needs to be a new call to ReadNextTransactionId() each
|
||||
* time a page gets deleted. See comments about the underlying assumption
|
||||
* below.
|
||||
*
|
||||
@@ -2559,7 +2559,7 @@ _bt_unlink_halfdead_page(Relation rel, Buffer leafbuf, BlockNumber scanblkno,
|
||||
* Mark the page itself deleted. It can be recycled when all current
|
||||
* transactions are gone. Storing GetTopTransactionId() would work, but
|
||||
* we're in VACUUM and would not otherwise have an XID. Having already
|
||||
* updated links to the target, ReadNewTransactionId() suffices as an
|
||||
* updated links to the target, ReadNextTransactionId() suffices as an
|
||||
* upper bound. Any scan having retained a now-stale link is advertising
|
||||
* in its PGPROC an xmin less than or equal to the value we read here. It
|
||||
* will continue to do so, holding back the xmin horizon, for the duration
|
||||
@@ -2570,7 +2570,7 @@ _bt_unlink_halfdead_page(Relation rel, Buffer leafbuf, BlockNumber scanblkno,
|
||||
Assert(P_ISHALFDEAD(opaque) || !P_ISLEAF(opaque));
|
||||
opaque->btpo_flags &= ~BTP_HALF_DEAD;
|
||||
opaque->btpo_flags |= BTP_DELETED;
|
||||
opaque->btpo.xact = ReadNewTransactionId();
|
||||
opaque->btpo.xact = ReadNextTransactionId();
|
||||
|
||||
/*
|
||||
* Remove the remaining tuples on the page. This keeps things simple for
|
||||
|
@@ -733,7 +733,7 @@ ActivateCommitTs(void)
|
||||
if (ShmemVariableCache->oldestCommitTsXid == InvalidTransactionId)
|
||||
{
|
||||
ShmemVariableCache->oldestCommitTsXid =
|
||||
ShmemVariableCache->newestCommitTsXid = ReadNewTransactionId();
|
||||
ShmemVariableCache->newestCommitTsXid = ReadNextTransactionId();
|
||||
}
|
||||
LWLockRelease(CommitTsLock);
|
||||
|
||||
|
@@ -548,7 +548,7 @@ GetStableLatestTransactionId(void)
|
||||
lxid = MyProc->lxid;
|
||||
stablexid = GetTopTransactionIdIfAny();
|
||||
if (!TransactionIdIsValid(stablexid))
|
||||
stablexid = ReadNewTransactionId();
|
||||
stablexid = ReadNextTransactionId();
|
||||
}
|
||||
|
||||
Assert(TransactionIdIsValid(stablexid));
|
||||
|
Reference in New Issue
Block a user