database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-03 22:24:49 +03:00
Code

Update comment about set_join_pathlist_hook().

Browse Source 
The comment introduced by commit e7cb7ee14 was a bit too terse, which
could lead to extensions doing different things within the hook function
than we intend to allow.  Extend the comment to explain what they can do
within the hook function.

Back-patch to all supported branches.

In passing, I rephrased a nearby comment that I recently added to the
back branches.

Reviewed by David Rowley and Andrei Lepikhov.

Discussion: https://postgr.es/m/CAPmGK15SBPA1nr3Aqsdm%2BYyS-ay0Ayo2BRYQ8_A2To9eLqwopQ%40mail.gmail.com
This commit is contained in:
Etsuro Fujita 2023-09-21 19:45:05 +09:00
parent 78df27e2ff
commit c7c4ce2be3
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/optimizer/path/joinpath.c
View File

@ -323,7 +323,8 @@ add_paths_to_joinrel(PlannerInfo *root,
/* /*
* createplan.c does not currently support handling of pseudoconstant * createplan.c does not currently support handling of pseudoconstant
* clauses assigned to joins pushed down by extensions; check if the * clauses assigned to joins pushed down by extensions; check if the
* restrictlist has such clauses, and if so, disallow pushing down joins. * restrictlist has such clauses, and if not, allow them to consider
* pushing down joins.
*/ */
if ((joinrel->fdwroutine && if ((joinrel->fdwroutine &&
joinrel->fdwroutine->GetForeignJoinPaths) || joinrel->fdwroutine->GetForeignJoinPaths) ||
@ -344,7 +345,10 @@ add_paths_to_joinrel(PlannerInfo *root,
jointype, &extra); jointype, &extra);
/* /*
* 6. Finally, give extensions a chance to manipulate the path list. * 6. Finally, give extensions a chance to manipulate the path list. They
* could add new paths (such as CustomPaths) by calling add_path(), or
* add_partial_path() if parallel aware. They could also delete or modify
* paths added by the core code.
*/ */
if (set_join_pathlist_hook && if (set_join_pathlist_hook &&
consider_join_pushdown) consider_join_pushdown)