database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-03 22:24:49 +03:00
Code

pg_upgrade: Fix some minor code issues

Browse Source 
96ef3b8ff1cf1950e897fd2f766d4bd9ef0d5d56 accidentally copied a not
applicable comment from the float8_pass_by_value code to the
data_checksums code.  Remove that.

87d3b35a1ca31a9d947a8f919a6006679216dff0 changed pg_upgrade to
checking the checksum version rather than just the Boolean presence of
checksums, but didn't change the field type in its ControlData struct
from bool.  So this would not work correctly if there ever is a
checksum version larger than 1.
This commit is contained in:
Peter Eisentraut 2022-08-13 00:00:41 +02:00
parent 560d052ebd
commit c7bc39cec7
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/bin/pg_upgrade/controldata.c
View File

@ -493,7 +493,6 @@ get_control_data(ClusterInfo *cluster, bool live_check)
pg_fatal("%d: controldata retrieval problem\n", __LINE__);
p++; /* remove ':' char */
/* used later for contrib check */
cluster->controldata.data_checksum_version = str2uint(p);
got_data_checksum_version = true;
}

2
src/bin/pg_upgrade/pg_upgrade.h
View File

@ -216,7 +216,7 @@ typedef struct
uint32 large_object;
bool date_is_int;
bool float8_pass_by_value;
bool data_checksum_version;
uint32 data_checksum_version;
} ControlData;
/*