mirror of
https://github.com/postgres/postgres.git
synced 2025-07-05 07:21:24 +03:00
Phase 2 of pgindent updates.
Change pg_bsd_indent to follow upstream rules for placement of comments
to the right of code, and remove pgindent hack that caused comments
following #endif to not obey the general rule.
Commit e3860ffa4d
wasn't actually using
the published version of pg_bsd_indent, but a hacked-up version that
tried to minimize the amount of movement of comments to the right of
code. The situation of interest is where such a comment has to be
moved to the right of its default placement at column 33 because there's
code there. BSD indent has always moved right in units of tab stops
in such cases --- but in the previous incarnation, indent was working
in 8-space tab stops, while now it knows we use 4-space tabs. So the
net result is that in about half the cases, such comments are placed
one tab stop left of before. This is better all around: it leaves
more room on the line for comment text, and it means that in such
cases the comment uniformly starts at the next 4-space tab stop after
the code, rather than sometimes one and sometimes two tabs after.
Also, ensure that comments following #endif are indented the same
as comments following other preprocessor commands such as #else.
That inconsistency turns out to have been self-inflicted damage
from a poorly-thought-through post-indent "fixup" in pgindent.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
This commit is contained in:
contrib
bloom
btree_gist
cube
dblink
file_fdw
fuzzystrmatch
hstore
intarray
isn
lo
ltree
pageinspect
pg_buffercache
pg_standby
pg_stat_statements
pg_trgm
pgcrypto
pgstattuple
postgres_fdw
sepgsql
spi
tablefunc
tcn
uuid-ossp
xml2
src
backend
access
brin
common
gin
gist
hash
heap
index
nbtree
rmgrdesc
spgist
transam
bootstrap
catalog
aclchk.cdependency.cheap.cindex.cindexing.cnamespace.cobjectaddress.cpartition.cpg_aggregate.cpg_constraint.cpg_operator.cpg_type.cstorage.c
commands
aggregatecmds.calter.canalyze.casync.ccluster.ccollationcmds.ccopy.cdbcommands.cevent_trigger.cextension.cfunctioncmds.cindexcmds.copclasscmds.coperatorcmds.cportalcmds.cproclang.csequence.ctablecmds.ctablespace.ctrigger.ctsearchcmds.ctypecmds.cuser.cvacuumlazy.cview.c
executor
execExpr.cexecExprInterp.cexecIndexing.cexecMain.cexecTuples.cexecUtils.cfunctions.cnodeAgg.cnodeBitmapHeapscan.cnodeBitmapIndexscan.cnodeBitmapOr.cnodeGather.cnodeGatherMerge.cnodeHash.cnodeHashjoin.cnodeIndexscan.cnodeLockRows.cnodeMergejoin.cnodeModifyTable.cnodeSamplescan.cnodeSeqscan.cnodeSetOp.cnodeTidscan.cnodeWindowAgg.cspi.ctqueue.c
lib
libpq
main
nodes
optimizer
geqo
geqo_cx.cgeqo_erx.cgeqo_misc.cgeqo_mutation.cgeqo_ox1.cgeqo_ox2.cgeqo_pmx.cgeqo_pool.cgeqo_px.cgeqo_recombination.c
path
plan
prep
util
parser
analyze.cparse_agg.cparse_clause.cparse_coerce.cparse_collate.cparse_cte.cparse_expr.cparse_func.cparse_node.cparse_oper.cparse_relation.cparse_utilcmd.c
port
atomics.c
dynloader
aix.hcygwin.hdarwin.cfreebsd.cfreebsd.hlinux.clinux.hnetbsd.cnetbsd.hopenbsd.copenbsd.hsolaris.hwin32.h
posix_sema.csysv_sema.csysv_shmem.cwin32_shmem.cpostmaster
autovacuum.cbgworker.cbgwriter.ccheckpointer.cfork_process.cpgarch.cpgstat.cpostmaster.cstartup.csyslogger.cwalwriter.c
regex
regc_color.cregc_lex.cregc_locale.cregc_nfa.cregc_pg_locale.cregcomp.crege_dfa.cregerror.cregexec.cregexport.c
replication
rewrite
statistics
storage
buffer
file
ipc
large_object
lmgr
page
smgr
tcop
tsearch
utils
adt
acl.carray_selfuncs.carrayfuncs.cascii.ccash.cdate.cdatetime.cfloat.cformatting.cgeo_ops.cint8.cjson.cjsonfuncs.clike_match.cnabstime.cname.cnumeric.cpg_locale.crangetypes_gist.crangetypes_selfuncs.crangetypes_typanalyze.cri_triggers.cruleutils.cselfuncs.ctsquery.ctsrank.ctsvector_op.cvarbit.cvarlena.cxml.c
cache
attoptcache.ccatcache.cinval.clsyscache.cplancache.crelcache.crelfilenodemap.crelmapper.csyscache.ctypcache.c
error
fmgr
hash
init
mb
misc
mmgr
resowner
sort
time
bin
initdb
pg_archivecleanup
pg_basebackup
pg_ctl
pg_dump
compress_io.cdumputils.cdumputils.hparallel.cparallel.hpg_backup.hpg_backup_archiver.cpg_backup_archiver.hpg_backup_tar.cpg_backup_utils.hpg_dump.cpg_dump.hpg_dump_sort.c
pg_resetwal
pg_rewind
pg_upgrade
pg_waldump
pgbench
psql
command.ccommand.hcommon.ccommon.hconditional.hcopy.ccrosstabview.hdescribe.cdescribe.hhelp.cinput.cinput.hlarge_obj.hmainloop.cmainloop.hprompt.cprompt.hsettings.hstartup.cstringutils.htab-complete.ctab-complete.hvariables.cvariables.h
scripts
common
fe_utils
include
access
amapi.hamvalidate.hattnum.hbrin.hbrin_internal.hbrin_page.hbrin_pageops.hbrin_revmap.hbrin_tuple.hbrin_xlog.hclog.hcommit_ts.hgenam.hgeneric_xlog.hgin.hgin_private.hginblock.hginxlog.hgist.hgist_private.hgistscan.hhash.hhash_xlog.hheapam.hheapam_xlog.hhio.hhtup.hhtup_details.hitup.hmultixact.hnbtree.hnbtxlog.hparallel.hprintsimple.hprinttup.hreloptions.hrelscan.hrewriteheap.hrmgr.hsdir.hskey.hslru.hspgist.hspgist_private.hspgxlog.hstratnum.hsubtrans.hsysattr.htimeline.htransam.htsmapi.htupconvert.htupdesc.htupmacs.htuptoaster.htwophase.htwophase_rmgr.hvalid.hvisibilitymap.hxact.hxlog.hxlog_internal.hxlogdefs.hxloginsert.hxlogreader.hxlogrecord.h
bootstrap
c.hcatalog
binary_upgrade.hcatalog.hdependency.hgenbki.hheap.hindex.hindexing.hnamespace.hobjectaccess.hobjectaddress.hopfam_internal.hpartition.hpg_aggregate.hpg_am.hpg_amop.hpg_amproc.hpg_attrdef.hpg_attribute.hpg_auth_members.hpg_authid.hpg_cast.hpg_class.hpg_collation.hpg_collation_fn.hpg_constraint.hpg_constraint_fn.hpg_control.hpg_conversion.hpg_conversion_fn.hpg_database.hpg_db_role_setting.hpg_default_acl.hpg_depend.hpg_description.hpg_enum.hpg_event_trigger.hpg_extension.hpg_foreign_data_wrapper.hpg_foreign_server.hpg_foreign_table.hpg_index.hpg_inherits.hpg_inherits_fn.hpg_init_privs.hpg_language.hpg_largeobject.hpg_largeobject_metadata.hpg_namespace.hpg_opclass.hpg_operator.hpg_operator_fn.hpg_opfamily.hpg_partitioned_table.hpg_pltemplate.hpg_policy.hpg_proc.hpg_proc_fn.hpg_publication.hpg_publication_rel.hpg_range.hpg_replication_origin.hpg_rewrite.hpg_seclabel.hpg_sequence.hpg_shdepend.hpg_shdescription.hpg_shseclabel.hpg_statistic.hpg_statistic_ext.hpg_subscription.hpg_subscription_rel.hpg_tablespace.hpg_transform.hpg_trigger.hpg_ts_config.hpg_ts_config_map.hpg_ts_dict.hpg_ts_parser.hpg_ts_template.hpg_type.hpg_type_fn.hpg_user_mapping.hstorage.hstorage_xlog.htoasting.h
commands
alter.hasync.hcluster.hcollationcmds.hcomment.hconversioncmds.hcopy.hcreateas.hdbcommands.hdbcommands_xlog.hdefrem.hdiscard.hevent_trigger.hexplain.hextension.hlockcmds.hmatview.hpolicy.hportalcmds.hprepare.hproclang.hpublicationcmds.hschemacmds.hseclabel.hsequence.hsubscriptioncmds.htablecmds.htablespace.htrigger.htypecmds.huser.hvacuum.hvariable.hview.h
common
base64.hconfig_info.hcontroldata_utils.hfe_memutils.hfile_utils.hint128.hip.hkeywords.hpg_lzcompress.hrelpath.hrestricted_token.hsaslprep.hscram-common.hsha2.hstring.hunicode_norm.hunicode_norm_table.husername.h
datatype
executor
execExpr.hexecParallel.hexecdebug.hexecdesc.hexecutor.hfunctions.hhashjoin.hinstrument.hnodeAgg.hnodeAppend.hnodeBitmapAnd.hnodeBitmapHeapscan.hnodeBitmapIndexscan.hnodeBitmapOr.hnodeCtescan.hnodeCustom.hnodeForeignscan.hnodeFunctionscan.hnodeGather.hnodeGatherMerge.hnodeGroup.hnodeHash.hnodeHashjoin.hnodeIndexonlyscan.hnodeIndexscan.hnodeLimit.hnodeLockRows.hnodeMaterial.hnodeMergeAppend.hnodeMergejoin.hnodeModifyTable.hnodeNamedtuplestorescan.hnodeNestloop.hnodeProjectSet.hnodeRecursiveunion.hnodeResult.hnodeSamplescan.hnodeSeqscan.hnodeSetOp.hnodeSort.hnodeSubplan.hnodeSubqueryscan.hnodeTableFuncscan.hnodeTidscan.hnodeUnique.hnodeValuesscan.hnodeWindowAgg.hnodeWorktablescan.hspi.hspi_priv.htablefunc.htqueue.htstoreReceiver.htuptable.h
fe_utils
fmgr.hforeign
funcapi.hgetaddrinfo.hgetopt_long.hlib
binaryheap.hbipartite_match.hhyperloglog.hilist.hknapsack.hpairingheap.hrbtree.hsimplehash.hstringinfo.h
libpq
mb
miscadmin.hnodes
bitmapset.hexecnodes.hextensible.hlockoptions.hmakefuncs.hmemnodes.hnodeFuncs.hnodes.hparams.hparsenodes.hpg_list.hplannodes.hprimnodes.hprint.hreadfuncs.hrelation.hreplnodes.htidbitmap.hvalue.h
optimizer
clauses.hcost.hgeqo.hgeqo_copy.hgeqo_gene.hgeqo_misc.hgeqo_mutation.hgeqo_pool.hgeqo_random.hgeqo_recombination.hgeqo_selection.hjoininfo.horclauses.hpathnode.hpaths.hplaceholder.hplancat.hplanmain.hplanner.hpredtest.hprep.hrestrictinfo.hsubselect.htlist.hvar.h
parser
analyze.hgramparse.hparse_agg.hparse_clause.hparse_coerce.hparse_collate.hparse_cte.hparse_enr.hparse_expr.hparse_func.hparse_node.hparse_oper.hparse_param.hparse_relation.hparse_target.hparse_type.hparse_utilcmd.hparser.hparsetree.hscanner.hscansup.h
pg_getopt.hpg_trace.hpgstat.hpgtime.hport.hport
portability
postgres.hpostgres_ext.hpostgres_fe.hpostmaster
autovacuum.hbgworker.hbgworker_internals.hbgwriter.hfork_process.hpgarch.hpostmaster.hstartup.hsyslogger.hwalwriter.h
regex
replication
basebackup.hlogicallauncher.hlogicalproto.hlogicalrelation.hlogicalworker.hmessage.horigin.houtput_plugin.hpgoutput.hslot.hsnapbuild.hsyncrep.hwalreceiver.hwalsender.hwalsender_private.hworker_internal.h
rewrite
rusagestub.hsnowball
statistics
storage
backendid.hblock.hbuf.hbuf_internals.hbuffile.hbufmgr.hbufpage.hchecksum.hcondition_variable.hcopydir.hdsm.hdsm_impl.hfd.hfreespace.hfsm_internals.hindexfsm.hipc.hitem.hitemid.hitemptr.hlarge_object.hlatch.hlmgr.hlock.hlockdefs.hlwlock.hoff.hpg_sema.hpg_shmem.hpmsignal.hpredicate.hpredicate_internals.hproc.hprocarray.hprocsignal.hreinit.hrelfilenode.hshm_mq.hshm_toc.hshmem.hsinval.hsinvaladt.hsmgr.hspin.hstandby.hstandbydefs.h
tcop
tsearch
utils
acl.haclchk_internal.harray.harrayaccess.hascii.hattoptcache.hbackend_random.hbuiltins.hbytea.hcash.hcatcache.hcombocid.hdate.hdatetime.hdatum.hdsa.hdynahash.hdynamic_loader.helog.hevtcache.hexpandeddatum.hfmgrtab.hfreepage.hgeo_decls.hguc.hguc_tables.hhsearch.hindex_selfuncs.hinet.hint8.hinval.hjson.hjsonapi.hjsonb.hlogtape.hlsyscache.hmemdebug.hmemutils.hnabstime.hnumeric.hpalloc.hpg_crc.hpg_locale.hpg_lsn.hpg_rusage.hplancache.hportal.hps_status.hqueryenvironment.hrangetypes.hrel.hrelcache.hrelfilenodemap.hrelmapper.hrelptr.hreltrigger.hresowner.hresowner_private.hrls.hruleutils.hsampling.hselfuncs.hsnapmgr.hsnapshot.hsortsupport.hspccache.hsyscache.htimeout.htimestamp.htqual.htuplesort.htuplestore.htypcache.htzparser.huuid.hxml.h
windowapi.hinterfaces
ecpg
ecpglib
include
datetime.hdecimal.hecpg-pthread-win32.hecpg_informix.hecpgerrno.hecpglib.hecpgtype.hpgtypes_date.hpgtypes_interval.hpgtypes_numeric.hpgtypes_timestamp.hsql3types.hsqlca.hsqlda-compat.hsqlda-native.hsqlda.hsqltypes.h
pgtypeslib
preproc
test
expected
libpq
pl
plperl
plpgsql
plpython
plpy_cursorobject.hplpy_elog.hplpy_exec.cplpy_exec.hplpy_main.cplpy_main.hplpy_planobject.hplpy_plpymodule.cplpy_plpymodule.hplpy_procedure.hplpy_resultobject.hplpy_spi.hplpy_subxactobject.hplpy_typeio.hplpy_util.cplpy_util.hplpython.h
tcl
port
chklocale.ccrypt.cdirent.cdirmod.cgetaddrinfo.cgetopt.cgetrusage.cmkdtemp.cpg_crc32c_sb8.cpg_crc32c_sse42.cpgsleep.cpqsignal.csnprintf.c
test
timezone
tools
pgindent
tutorial
@ -2570,7 +2570,7 @@ EvalPlanQualFetch(EState *estate, Relation relation, int lockmode,
|
||||
break;
|
||||
case LockWaitSkip:
|
||||
if (!ConditionalXactLockTableWait(SnapshotDirty.xmax))
|
||||
return NULL; /* skip instead of waiting */
|
||||
return NULL; /* skip instead of waiting */
|
||||
break;
|
||||
case LockWaitError:
|
||||
if (!ConditionalXactLockTableWait(SnapshotDirty.xmax))
|
||||
|
Reference in New Issue
Block a user