database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-03 22:24:49 +03:00
Code

Use "g" not "f" format in ecpg's PGTYPESnumeric_from_double().

Browse Source 
The previous coding could overrun the provided buffer size for a very large
input, or lose precision for a very small input.  Adopt the methodology
that's been in use in the equivalent backend code for a long time.

Per private report from Bas van Schaik.  Back-patch to all supported
branches.
This commit is contained in:
Tom Lane 2015-12-01 11:42:25 -05:00
parent 6fe8ca0a2f
commit c79bdc9904
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/interfaces/ecpg/pgtypeslib/numeric.c
View File

@ -2,6 +2,7 @@
#include "postgres_fe.h" #include "postgres_fe.h"
#include <ctype.h> #include <ctype.h>
#include <float.h>
#include <limits.h> #include <limits.h>
#include "extern.h" #include "extern.h"
@ -1497,11 +1498,11 @@ PGTYPESnumeric_copy(numeric *src, numeric *dst)
int int
PGTYPESnumeric_from_double(double d, numeric *dst) PGTYPESnumeric_from_double(double d, numeric *dst)
{ {
char buffer[100]; char buffer[DBL_DIG + 100];
numeric *tmp; numeric *tmp;
int i; int i;
if (sprintf(buffer, "%f", d) == 0) if (sprintf(buffer, "%.*g", DBL_DIG, d) <= 0)
return -1; return -1;
if ((tmp = PGTYPESnumeric_from_asc(buffer, NULL)) == NULL) if ((tmp = PGTYPESnumeric_from_asc(buffer, NULL)) == NULL)