database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-21 00:42:43 +03:00
Code Activity

Revert "Make vacuum a bit more verbose to debug BF failure."

Browse Source 
This reverts commit 49967da65a.

Enough time has passed that we can be confident that 07f32fcd23
resolved the issue. Therefore we can remove the temporary debugging
aids.

Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/E1k7tGP-0005V0-5k@gemulon.postgresql.org
This commit is contained in:
Andres Freund
2020-08-20 12:59:00 -07:00
parent 0784c33372
commit c62a0a49f3
2 changed files with 1 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/backend/access/heap/heapam.c
View File

@@ -6048,16 +6048,7 @@ FreezeMultiXactId(MultiXactId multi, uint16 t_infomask,
TransactionIdIsInProgress(members[i].xid)) TransactionIdIsInProgress(members[i].xid))
{ {
/* running locker cannot possibly be older than the cutoff */ /* running locker cannot possibly be older than the cutoff */
if (TransactionIdPrecedes(members[i].xid, cutoff_xid)) Assert(!TransactionIdPrecedes(members[i].xid, cutoff_xid));
{
/* temporary on-bf debugging */
elog(PANIC, "too old alive locker: multi: %u, member xid: %u, memb-current: %d, memb-progress: %d, cutoff: %u, cutoff-multi: %u, relfrozenxid: %u, relminmxid: %u",
multi, members[i].xid,
TransactionIdIsCurrentTransactionId(members[i].xid),
TransactionIdIsInProgress(members[i].xid),
cutoff_xid, cutoff_multi,
relfrozenxid, relminmxid);
}
newmembers[nnewmembers++] = members[i]; newmembers[nnewmembers++] = members[i];
has_lockers = true; has_lockers = true;
} }

7
src/backend/access/heap/vacuumlazy.c
View File

@@ -1350,14 +1350,7 @@ lazy_scan_heap(Relation onerel, VacuumParams *params, LVRelStats *vacrelstats,
if (HeapTupleIsHotUpdated(&tuple) || if (HeapTupleIsHotUpdated(&tuple) ||
HeapTupleIsHeapOnly(&tuple) || HeapTupleIsHeapOnly(&tuple) ||
params->index_cleanup == VACOPT_TERNARY_DISABLED) params->index_cleanup == VACOPT_TERNARY_DISABLED)
{
/* temporary on-bf debugging */
elog(LOG, "treating dead HOT tuple (updated %d, heap only: %d, index cleanup: %d) as alive",
HeapTupleIsHotUpdated(&tuple), HeapTupleIsHeapOnly(&tuple),
params->index_cleanup == VACOPT_TERNARY_DISABLED);
nkeep += 1; nkeep += 1;
}
else else
tupgone = true; /* we can delete the tuple */ tupgone = true; /* we can delete the tuple */
all_visible = false; all_visible = false;