database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-17 17:02:08 +03:00
Code Activity

Fix comment for MAX_BACKENDS.

Browse Source 
This comment mentions that we check that the configured number of
backends does not exceed MAX_BACKENDS in RegisterBackgroundWorker()
and relevant GUC check hooks, neither of which has those checks
anymore.  To fix, adjust this comment to say that we do the check
in InitializeMaxBackends().

Oversights in commits 6bc8ef0b7f and 0b1fe1413e.

Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/Z7zOEzz8lNjaU9yf%40nathan
This commit is contained in:
Nathan Bossart
2025-02-24 15:02:09 -06:00
parent e87c14b19e
commit c56e8af75e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/include/storage/procnumber.h
View File

@ -32,8 +32,8 @@ typedef int ProcNumber;
* currently realistic configurations. Even if that limitation were removed, * currently realistic configurations. Even if that limitation were removed,
* we still could not a) exceed 2^23-1 because inval.c stores the ProcNumber * we still could not a) exceed 2^23-1 because inval.c stores the ProcNumber
* as a 3-byte signed integer, b) INT_MAX/4 because some places compute * as a 3-byte signed integer, b) INT_MAX/4 because some places compute
* 4*MaxBackends without any overflow check. This is rechecked in the * 4*MaxBackends without any overflow check. We check that the configured
* relevant GUC check hooks and in RegisterBackgroundWorker(). * number of backends does not exceed MAX_BACKENDS in InitializeMaxBackends().
*/ */
#define MAX_BACKENDS_BITS 18 #define MAX_BACKENDS_BITS 18
#define MAX_BACKENDS ((1U << MAX_BACKENDS_BITS)-1) #define MAX_BACKENDS ((1U << MAX_BACKENDS_BITS)-1)