database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-24 10:47:04 +03:00
Code

Fix comment in libpq OpenSSL code about why a substitue BIO is used.

Browse Source 
The comment was copy-pasted from the backend code along with the
implementation, but libpq has different reasons for using the BIO.
This commit is contained in:
Heikki Linnakangas 2015-02-16 23:05:20 +02:00
parent 1c2b7c0879
commit c478959a00
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/interfaces/libpq/fe-secure-openssl.c
View File

@ -1569,12 +1569,9 @@ PQsslAttribute(PGconn *conn, const char *attribute_name)
}
/*
* Private substitute BIO: this does the sending and receiving using send() and
* recv() instead. This is so that we can enable and disable interrupts
* just while calling recv(). We cannot have interrupts occurring while
* the bulk of openssl runs, because it uses malloc() and possibly other
* non-reentrant libc facilities. We also need to call send() and recv()
* directly so it gets passed through the socket/signals layer on Win32.
* Private substitute BIO: this does the sending and receiving using
* pqsecure_raw_write() and pqsecure_raw_read() instead, to allow those
* functions to disable SIGPIPE and give better error messages on I/O errors.
*
* These functions are closely modelled on the standard socket BIO in OpenSSL;
* see sock_read() and sock_write() in OpenSSL's crypto/bio/bss_sock.c.