From c4528fdfa903c74cf99837a554bd3c7e115bb366 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Wed, 9 Oct 2024 09:34:34 +0200 Subject: [PATCH] Remove incorrect function import from pgindent Commit 149ac7d4559 which re-implemented pgindent in Perl explicitly imported the devnull function from File::Spec, but the module does not export anything. In recent versions of Perl calling a missing import function cause a warning, which combined with warnings being fatal cause pgindent to error out. Backpatch to all supported versions. Author: Erik Wienhold Reviewed-by: Andrew Dunstan Reviewed-by: Daniel Gustafsson Discusson: https://postgr.es/m/2372cd74-11b0-46f9-b28e-8f9627215d19@ewie.name Backpatch-through: v12 --- src/tools/pgindent/pgindent | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/pgindent/pgindent b/src/tools/pgindent/pgindent index 77c8118e5d7..e889af6b1e4 100755 --- a/src/tools/pgindent/pgindent +++ b/src/tools/pgindent/pgindent @@ -7,7 +7,7 @@ use warnings FATAL => 'all'; use Cwd qw(abs_path getcwd); use File::Find; -use File::Spec qw(devnull); +use File::Spec; use File::Temp; use IO::Handle; use Getopt::Long;