database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-24 10:47:04 +03:00
Code

Cleanup useless assignments and checks

Browse Source 
This cleans up a couple of areas:
- Remove XLogSegNo calculation for the last WAL segment in backup in
xlog.c (7d70809 has moved this logic entirely to xlogbackup.c when
building the contents of the backup history file).
- Remove check on log_min_duration in analyze.c, as it is already true
where this code path is reached.
- Simplify call to find_option() in guc.c.

Author: Ranier Vilela
Reviewed-by: Masahiko Sawada
Discussion: https://postgr.es/m/CAEudQArCDQQiPiFR16=yu9k5s2tp4tgEe1U1ZbkW4ofx81AWWQ@mail.gmail.com
This commit is contained in:
Michael Paquier 2022-10-04 13:16:23 +09:00
parent 62be9e4cdc
commit c42cd05c58
3 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/backend/access/transam/xlog.c
View File

@ -8733,7 +8733,6 @@ do_pg_backup_stop(BackupState *state, bool waitforarchive)
*/ */
RequestXLogSwitch(false); RequestXLogSwitch(false);
XLByteToPrevSeg(state->stoppoint, _logSegNo, wal_segment_size);
state->stoptime = (pg_time_t) time(NULL); state->stoptime = (pg_time_t) time(NULL);
/* /*

3
src/backend/commands/analyze.c
View File

@ -360,8 +360,7 @@ do_analyze_rel(Relation onerel, VacuumParams *params,
} }
pg_rusage_init(&ru0); pg_rusage_init(&ru0);
if (params->log_min_duration >= 0) starttime = GetCurrentTimestamp();
starttime = GetCurrentTimestamp();
} }
/* /*

4
src/backend/utils/misc/guc.c
View File

@ -5262,12 +5262,10 @@ read_nondefault_variables(void)
for (;;) for (;;)
{ {
struct config_generic *record;
if ((varname = read_string_with_null(fp)) == NULL) if ((varname = read_string_with_null(fp)) == NULL)
break; break;
if ((record = find_option(varname, true, false, FATAL)) == NULL) if (find_option(varname, true, false, FATAL) == NULL)
elog(FATAL, "failed to locate variable \"%s\" in exec config params file", varname); elog(FATAL, "failed to locate variable \"%s\" in exec config params file", varname);
if ((varvalue = read_string_with_null(fp)) == NULL) if ((varvalue = read_string_with_null(fp)) == NULL)