database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-03 20:02:46 +03:00
Code Activity

Avoid uninitialized value error in TAP tests' Cluster->psql

Browse Source 
If the method is called in scalar context and we didn't pass in a stderr
handle, one won't be created. However, some error paths assume that it
exists, so in this case create a dummy stderr to avoid the resulting
perl error.

Per gripe from Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru> and
adapted from his patch.

Discussion: https://postgr.es/m/378eac5de4b8ecb5be7bcdf2db9d2c4d@postgrespro.ru
This commit is contained in:
Andrew Dunstan
2025-06-30 09:49:31 -04:00
parent 40a96cd148
commit c3e28e9fd9
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/perl/PostgreSQL/Test/Cluster.pm
View File

@ -2199,6 +2199,14 @@ sub psql
$ret = $?; $ret = $?;
}; };
my $exc_save = $@; my $exc_save = $@;
# we need a dummy $stderr from hereon, if we didn't collect it
if (! defined $stderr)
{
my $errtxt = "<not collected>";
$stderr = \$errtxt;
}
if ($exc_save) if ($exc_save)
{ {