database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-04 12:42:24 +03:00
Code

Fix _bt_allequalimage() call within critical section.

Browse Source 
_bt_allequalimage() does complicated things, so it's not OK to call it
in a critical section. Per buildfarm failure on 'prion', which uses
-DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE options.

Discussion: https://www.postgresql.org/message-id/6e5bbc08-cdfc-b2b3-9e23-1a914b9850a9@iki.fi
Backpatch-through: 16, like commit ccadf73163 that introduced this
This commit is contained in:
Heikki Linnakangas 2023-08-23 18:08:40 +03:00
parent 6bc1fd4e60
commit c3b874c431
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/access/nbtree/nbtree.c
View File

@ -151,6 +151,7 @@ bthandler(PG_FUNCTION_ARGS)
void void
btbuildempty(Relation index) btbuildempty(Relation index)
{ {
bool allequalimage = _bt_allequalimage(index, false);
Buffer metabuf; Buffer metabuf;
Page metapage; Page metapage;
@ -169,7 +170,7 @@ btbuildempty(Relation index)
START_CRIT_SECTION(); START_CRIT_SECTION();
metapage = BufferGetPage(metabuf); metapage = BufferGetPage(metabuf);
_bt_initmetapage(metapage, P_NONE, 0, _bt_allequalimage(index, false)); _bt_initmetapage(metapage, P_NONE, 0, allequalimage);
MarkBufferDirty(metabuf); MarkBufferDirty(metabuf);
log_newpage_buffer(metabuf, true); log_newpage_buffer(metabuf, true);