From c30be9787bd9808631b72843b0a93f06ce775dd0 Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Wed, 5 Nov 2014 17:12:23 -0500 Subject: [PATCH] Fix thinko in commit 2bd9e412f92bc6a68f3e8bcb18e04955cc35001d. Obviously, every translation unit should not be declaring this separately. It needs to be PGDLLIMPORT as well, to avoid breaking third-party code that uses any of the functions that the commit mentioned above changed to macros. --- src/backend/libpq/pqcomm.c | 2 ++ src/include/libpq/libpq.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c index dcbb704c6a5..74161970ab5 100644 --- a/src/backend/libpq/pqcomm.c +++ b/src/backend/libpq/pqcomm.c @@ -105,6 +105,8 @@ char *Unix_socket_group; /* Where the Unix socket files are (list of palloc'd strings) */ static List *sock_paths = NIL; +PQcommMethods *PqCommMethods; + /* * Buffers for low-level I/O. diff --git a/src/include/libpq/libpq.h b/src/include/libpq/libpq.h index 409f3d7786e..2a61a9e143d 100644 --- a/src/include/libpq/libpq.h +++ b/src/include/libpq/libpq.h @@ -49,7 +49,7 @@ typedef struct void (*endcopyout)(bool errorAbort); } PQcommMethods; -PQcommMethods *PqCommMethods; +extern PGDLLIMPORT PQcommMethods *PqCommMethods; #define pq_comm_reset() (PqCommMethods->comm_reset()) #define pq_flush() (PqCommMethods->flush())