1
0
mirror of https://github.com/postgres/postgres.git synced 2025-10-25 13:17:41 +03:00

Rename pending_list_cleanup_size to gin_pending_list_limit.

Since this parameter is only for GIN index, it's better to
add "gin" to the parameter name for easier understanding.
This commit is contained in:
Fujii Masao
2014-11-13 12:14:48 +09:00
parent 677708032c
commit c291503b1c
13 changed files with 23 additions and 23 deletions

View File

@@ -218,7 +218,7 @@ static relopt_int intRelOpts[] =
},
{
{
"pending_list_cleanup_size",
"gin_pending_list_limit",
"Maximum size of the pending list for this GIN index, in kilobytes.",
RELOPT_KIND_GIN
},

View File

@@ -26,7 +26,7 @@
#include "utils/rel.h"
/* GUC parameter */
int pending_list_cleanup_size = 0;
int gin_pending_list_limit = 0;
#define GIN_PAGE_FREESIZE \
( BLCKSZ - MAXALIGN(SizeOfPageHeaderData) - MAXALIGN(sizeof(GinPageOpaqueData)) )
@@ -426,7 +426,7 @@ ginHeapTupleFastInsert(GinState *ginstate, GinTupleCollector *collector)
* call it when it can do all the work in a single collection cycle. In
* non-vacuum mode, it shouldn't require maintenance_work_mem, so fire it
* while pending list is still small enough to fit into
* pending_list_cleanup_size.
* gin_pending_list_limit.
*
* ginInsertCleanup() should not be called inside our CRIT_SECTION.
*/

View File

@@ -526,7 +526,7 @@ ginoptions(PG_FUNCTION_ARGS)
int numoptions;
static const relopt_parse_elt tab[] = {
{"fastupdate", RELOPT_TYPE_BOOL, offsetof(GinOptions, useFastUpdate)},
{"pending_list_cleanup_size", RELOPT_TYPE_INT, offsetof(GinOptions,
{"gin_pending_list_limit", RELOPT_TYPE_INT, offsetof(GinOptions,
pendingListCleanupSize)}
};

View File

@@ -2543,12 +2543,12 @@ static struct config_int ConfigureNamesInt[] =
},
{
{"pending_list_cleanup_size", PGC_USERSET, CLIENT_CONN_STATEMENT,
{"gin_pending_list_limit", PGC_USERSET, CLIENT_CONN_STATEMENT,
gettext_noop("Sets the maximum size of the pending list for GIN index."),
NULL,
GUC_UNIT_KB
},
&pending_list_cleanup_size,
&gin_pending_list_limit,
4096, 64, MAX_KILOBYTES,
NULL, NULL, NULL
},

View File

@@ -519,7 +519,7 @@
#bytea_output = 'hex' # hex, escape
#xmlbinary = 'base64'
#xmloption = 'content'
#pending_list_cleanup_size = 4MB
#gin_pending_list_limit = 4MB
# - Locale and Formatting -

View File

@@ -1172,7 +1172,7 @@ psql_completion(const char *text, int start, int end)
pg_strcasecmp(prev_wd, "(") == 0)
{
static const char *const list_INDEXOPTIONS[] =
{"fillfactor", "fastupdate", "pending_list_cleanup_size", NULL};
{"fillfactor", "fastupdate", "gin_pending_list_limit", NULL};
COMPLETE_WITH_LIST(list_INDEXOPTIONS);
}

View File

@@ -67,7 +67,7 @@ typedef char GinTernaryValue;
/* GUC parameters */
extern PGDLLIMPORT int GinFuzzySearchLimit;
extern int pending_list_cleanup_size;
extern int gin_pending_list_limit;
/* ginutil.c */
extern void ginGetStats(Relation index, GinStatsData *stats);

View File

@@ -326,7 +326,7 @@ typedef struct GinOptions
((relation)->rd_options && \
((GinOptions *) (relation)->rd_options)->pendingListCleanupSize != -1 ? \
((GinOptions *) (relation)->rd_options)->pendingListCleanupSize : \
pending_list_cleanup_size)
gin_pending_list_limit)
/* Macros for buffer lock/unlock operations */

View File

@@ -2244,14 +2244,14 @@ DROP TABLE array_gin_test;
-- Test GIN index's reloptions
--
CREATE INDEX gin_relopts_test ON array_index_op_test USING gin (i)
WITH (FASTUPDATE=on, PENDING_LIST_CLEANUP_SIZE=128);
WITH (FASTUPDATE=on, GIN_PENDING_LIST_LIMIT=128);
\d+ gin_relopts_test
Index "public.gin_relopts_test"
Column | Type | Definition | Storage
--------+---------+------------+---------
i | integer | i | plain
gin, for table "public.array_index_op_test"
Options: fastupdate=on, pending_list_cleanup_size=128
Options: fastupdate=on, gin_pending_list_limit=128
--
-- HASH

View File

@@ -658,7 +658,7 @@ DROP TABLE array_gin_test;
-- Test GIN index's reloptions
--
CREATE INDEX gin_relopts_test ON array_index_op_test USING gin (i)
WITH (FASTUPDATE=on, PENDING_LIST_CLEANUP_SIZE=128);
WITH (FASTUPDATE=on, GIN_PENDING_LIST_LIMIT=128);
\d+ gin_relopts_test
--